Skip to contentSkip to conversation

media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in ti_csi2rx_request_max_ppc()

PATCH In review Dan Carpenter 2 participants 2 messages Aug 27, 2025

Subsystems (3)
Media (V4L/DVB) Kernel janitors TI J721E CSI2RX driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 media: ti: j721e-csi2rx: Fix NULL vs IS_ERR() bug in ti_csi2rx_request_max_ppc()

The media_entity_remote_source_pad_unique() function never returns NULL, it returns error pointers. Change this check from a NULL check to an IS_ERR() check.

Fixes 31f91c5224cd ("media: ti: j721e-csi2rx: Support multiple pixels per clock")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +1 -1
index 3992f8b754b7..b75aa363d1bf 100644
@@ -497,7 +497,7 @@ static void ti_csi2rx_request_max_ppc(struct ti_csi2rx_dev *csi)
 	int ret;
 
 	pad = media_entity_remote_source_pad_unique(&csi->vdev.entity);
-	if (!pad)
+	if (IS_ERR(pad))
 		return;
 
 	ret = cdns_csi2rx_negotiate_ppc(csi->source, pad->index, &ppc);
Signature · 1 line
2.47.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Dan,

Quoting Dan Carpenter (2025-08-27 18:32:57)

Quoted 15 lines

The media_entity_remote_source_pad_unique() function never returns NULL, it returns error pointers. Change this check from a NULL check to an IS_ERR() check.

Fixes 31f91c5224cd ("media: ti: j721e-csi2rx: Support multiple pixels per clock")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +0 -0
index 3992f8b754b7..b75aa363d1bf 100644

drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c static void ti_csi2rx_request_max_ppc(struct ti_csi2rx_dev *csi) · line 500

Quoted 5 lines
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +1 -1
@@ -497,7 +497,7 @@ static void ti_csi2rx_request_max_ppc(struct ti_csi2rx_dev *csi)
        int ret;
 
        pad = media_entity_remote_source_pad_unique(&csi->vdev.entity);
-       if (!pad)
+       if (IS_ERR(pad))

Argh, my bad. Thanks for the quick fix.

Reviewed-by Jai Luthra <[email protected]>
Quoted 6 lines
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +0 -0
                return;
 
        ret = cdns_csi2rx_negotiate_ppc(csi->source, pad->index, &ppc);
Signature · 1 line
2.47.2