Skip to contentSkip to conversation

staging: iio: adc: ad7816: Drop unnecessary dev_set_drvdata() call

PATCH Applied Salah Triki 3 participants 3 messages Aug 19, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: iio: adc: ad7816: Drop unnecessary dev_set_drvdata() call

Remove the call to dev_set_drvdata() and the associated comment since private data is never read.

---
Changes in v2 :
- Remove spi_set_drvdata() and outdated comment as suggested by David Lechner
- Update commit title and message

 drivers/staging/iio/adc/ad7816.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/iio/adc/ad7816.c +0 -2
index 4774df778de9..172acf135f3b 100644
@@ -359,8 +359,6 @@ static int ad7816_probe(struct spi_device *spi_dev)
 	if (!indio_dev)
 		return -ENOMEM;
 	chip = iio_priv(indio_dev);
-	/* this is only used for device removal purposes */
-	dev_set_drvdata(&spi_dev->dev, indio_dev);
 
 	chip->spi_dev = spi_dev;
 	for (i = 0; i <= AD7816_CS_MAX; i++)
Signature · 1 line
2.43.0
maintainer Applied
#2 lore raw
Quoted 9 lines · On Tue, 19 Aug 2025 10:05:09 -0500 David Lechner <[email protected]> wrote:
Quoted 6 lines · Salah Triki

Remove the call to dev_set_drvdata() and the associated comment since private data is never read.

---
Changes in v2 :

Applied, thanks!

This motivated to do my periodic can I drop this driver yet check against my usual rule of once it's obsolete from the supplier and no significant work on the driver (staging only I'm less keen to remove drives in good condition!)
Unfortunately 7817 which it supports is still in production :( I then checked the other drivers still there and they all cover production parts as well.

This is a pretty simple device and probably a good target for someone who wants to try their first driver. It would be a near rewrite as this code is miles off ABI wise.

Doesn't look like there is a currently available dev board, but it's available in a TSSOP and will run on wide range of voltages so not a challenge for someone to give a go on a break out board.

Just thought I'd mention that and see if anyone jumped on it ;)

Jonathan

p.s. One day I'll just decide to delete all the remaining staging drivers.
Analog folk, they are all yours! I can't blame any of you though as I think the first stuff from Michael was the following year.