Skip to contentSkip to conversation

drm: bridge: waveshare-dsi: Fix NULL vs IS_ERR() check in probe()

PATCH In review Dan Carpenter 2 participants 2 messages Aug 21, 2025 – Aug 22, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: bridge: waveshare-dsi: Fix NULL vs IS_ERR() check in probe()

The devm_drm_bridge_alloc() function returns error pointers, it never returns NULL. Fix the checking to match.

Fixes dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
---
 drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/waveshare-dsi.c +2 -2
index 01c70e7d3d3b..43f4e7412d72 100644
@@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
 	int ret;
 
 	ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
-	if (!ws)
-		return -ENOMEM;
+	if (IS_ERR(ws))
+		return PTR_ERR(ws);
 
 	ws->dev = dev;
 
Signature · 1 line
2.47.2
#1 lore raw
Quoted 5 lines · Dan Carpenter

The devm_drm_bridge_alloc() function returns error pointers, it never returns NULL. Fix the checking to match.

Fixes dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")

Hi,

This change already sent by Ying Liu: https://lore.kernel.org/all/[email protected]/

Regards,
Joseph

Quoted 22 lines
---
 drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/waveshare-dsi.c +2 -2
index 01c70e7d3d3b..43f4e7412d72 100644
@@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
 	int ret;
 
 	ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
-	if (!ws)
-		return -ENOMEM;
+	if (IS_ERR(ws))
+		return PTR_ERR(ws);
 
 	ws->dev = dev;
 
Signature · 1 line
2.47.2