Skip to contentSkip to conversation

evilwm: fix compilation with external toolchains

PATCH Superseded Waldemar Brodkorb 2 participants 3 messages Aug 28, 2025 – Aug 29, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 evilwm: fix compilation with external toolchains

Switch to generic-package, as the configure script isn't really a autotool generated script. This fixes building evilwm with an external toolchain.

---
 package/evilwm/evilwm.mk | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
package/evilwm/evilwm.mk +23 -1
index 78b531095b..22116b7714 100644
@@ -18,4 +18,26 @@ endef
 
 EVILWM_POST_INSTALL_TARGET_HOOKS += EVILWM_INSTALL_XSESSION_FILE
 
-$(eval $(autotools-package))
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
+EVILWM_CONF_OPTS += --host=$(TOOLCHAIN_EXTERNAL_PREFIX)
+else
+EVILWM_CONF_OPTS += --host=$(GNU_TARGET_NAME)
+endif
+
+# the configure script is not generated by autoconf
+define EVILWM_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure \
+		--prefix=/usr \
+		$(EVILWM_CONF_OPTS) \
+	)
+endef
+
+define EVILWM_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define EVILWM_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
2.47.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 14 lines · Waldemar Brodkorb

Switch to generic-package, as the configure script isn't really a autotool generated script. This fixes building evilwm with an external toolchain.

---
  package/evilwm/evilwm.mk | 24 +++++++++++++++++++++++-
  1 file changed, 23 insertions(+), 1 deletion(-)
package/evilwm/evilwm.mk +0 -0
index 78b531095b..22116b7714 100644

package/evilwm/evilwm.mk endef · line 24

Quoted 8 lines
package/evilwm/evilwm.mk +4 -1
@@ -18,4 +18,26 @@ endef
 
  EVILWM_POST_INSTALL_TARGET_HOOKS += EVILWM_INSTALL_XSESSION_FILE
 
-$(eval $(autotools-package))
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
+EVILWM_CONF_OPTS += --host=$(TOOLCHAIN_EXTERNAL_PREFIX)
+else
+EVILWM_CONF_OPTS += --host=$(GNU_TARGET_NAME)

Could we use TARGET_CROSS here (which includes the full path as well) instead
of open-coding the condition?

package/evilwm/evilwm.mk endef · line 30

Quoted 6 lines
package/evilwm/evilwm.mk +6 -0
+endif
+
+# the configure script is not generated by autoconf
+define EVILWM_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure \
+		--prefix=/usr \

Looking at the configure script, I think it would be better to pass all
possible options: host, prefix, mandir, CFLAGS and LDFLAGS.

Regards,
Arnout

package/evilwm/evilwm.mk endef · line 43

Quoted 13 lines
package/evilwm/evilwm.mk +13 -0
+		$(EVILWM_CONF_OPTS) \
+	)
+endef
+
+define EVILWM_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define EVILWM_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
Quoted 8 lines · Arnout Vandecappelle
Quoted 5 lines · Waldemar Brodkorb

Switch to generic-package, as the configure script isn't really a autotool generated script. This fixes building evilwm with an external toolchain.

Also please include a Fixes: line, e.g.
https://autobuild.buildroot.org/results/250/25040ce7e94acf8f92c24db895d7dea081de1d7a

Regards,
Arnout

Quoted 32 lines
Quoted 11 lines

---
  package/evilwm/evilwm.mk | 24 +++++++++++++++++++++++-

  1 file changed, 23 insertions(+), 1 deletion(-)
package/evilwm/evilwm.mk +0 -0
index 78b531095b..22116b7714 100644
@@ -18,4 +18,26 @@ endef

  EVILWM_POST_INSTALL_TARGET_HOOKS += EVILWM_INSTALL_XSESSION_FILE -$(eval $(autotools-package))

package/evilwm/evilwm.mk endef · line 24

Quoted 4 lines
package/evilwm/evilwm.mk +4 -0
+ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
+EVILWM_CONF_OPTS += --host=$(TOOLCHAIN_EXTERNAL_PREFIX)
+else
+EVILWM_CONF_OPTS += --host=$(GNU_TARGET_NAME)

 Could we use TARGET_CROSS here (which includes the full path as well) instead
of open-coding the condition?

package/evilwm/evilwm.mk endef · line 30

Quoted 6 lines
package/evilwm/evilwm.mk +6 -0
+endif
+
+# the configure script is not generated by autoconf
+define EVILWM_CONFIGURE_CMDS
+    (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure \
+        --prefix=/usr \

 Looking at the configure script, I think it would be better to pass all
possible options: host, prefix, mandir, CFLAGS and LDFLAGS.

 Regards,
 Arnout

Quoted 14 lines

package/evilwm/evilwm.mk endef · line 43

Quoted 13 lines

+        $(EVILWM_CONF_OPTS) \
+    )

package/evilwm/evilwm.mk +11 -0
+endef
+
+define EVILWM_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define EVILWM_INSTALL_TARGET_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot