mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe
Subsystems (3)
PATCH 1/1 mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe
The dma_alloc_noncoherent() function doesn't return error pointers, it returns NULL on error. Fix the error checking to match.
--- drivers/mtd/nand/ecc-realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/ecc-realtek.c +2 -2
@@ -418,8 +418,8 @@ static int rtl_ecc_probe(struct platform_device *pdev) rtlc->buf =dma_alloc_noncoherent (dev,RTL_ECC_DMA_SIZE , &rtlc->buf_dma,DMA_BIDIRECTIONAL ,GFP_KERNEL ); -if (IS_ERR (rtlc->buf)) -return PTR_ERR (rtlc->buf); +if (!rtlc->buf) +return -ENOMEM ; rtlc->dev = dev; rtlc->engine.dev = dev;
Signature · 1 line
2.51.0
Quoted 5 lines
Von: Dan Carpenter <[email protected]>
Gesendet: Freitag, 3. Oktober 2025 11:30The
dma_alloc_noncoherent()function doesn't return error pointers, it returns NULL on error. Fix the error checking to match.
Hi Dan,
thanks for the quick fix.
Markus
Quoted 5 lines · Dan Carpenter
The
dma_alloc_noncoherent()function doesn't return error pointers, it returns NULL on error. Fix the error checking to match.Fixes 3148d0e5b1c5 ("mtd: nand: realtek-ecc: Add Realtek external ECC engine support")Signed-off-by Dan Carpenter <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 4 lines · Dan Carpenter
The
dma_alloc_noncoherent()function doesn't return error pointers, it returns NULL on error. Fix the error checking to match.
Applied to mtd/fixes, thanks!
[1/1] mtd: nand: realtek-ecc: Fix a IS_ERR() vs NULL bug in probe
commit: 9225f02ff201837e1443076f37a3c008140d1835
Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).
Kind regards,
Miquèl