tools build: Don't assume libtracefs-devel is always available
PATCH v2 1/1 tools build: Don't assume libtracefs-devel is always available
perf doesn't use libtracefs and so it doesn't make sense to assume it is always available when building test-all.bin, defeating the feature check speedup it provides.
The other tools/build/ users such as rtla, rv, etc call $(feature_check libtracefs) to check its availability instead of using the test-all.bin mechanism, stopping the build and asking for libtracefs-devel to be installed.
Remove it from FEATURE_TESTS_BASIC to not have it as available, as noted by Ian Rogers during review.
--- tools/build/Makefile.feature | 1 - tools/build/feature/test-all.c | 5 ----- 2 files changed, 6 deletions(-)
tools/build/Makefile.feature +0 -1
@@ -83,7 +83,6 @@ FEATURE_TESTS_BASIC := \ libpython \ libslang \ libtraceevent \ - libtracefs \ libcpupower \ pthread-attr-setaffinity-np \ pthread-barrier \
tools/build/feature/test-all.c +0 -5
@@ -150,10 +150,6 @@# include "test-libtraceevent.c" #undef main -#define main main_test_libtracefs -# include "test-libtracefs.c" -#undef main -int main (int argc,char *argv[]) {main_test_libpython ();
@@ -187,7 +183,6 @@ int main(int argc, char *argv[])main_test_reallocarray ();main_test_libzstd ();main_test_libtraceevent (); -main_test_libtracefs ();return 0 ; }
Signature · 1 line
2.49.0
Quoted 13 lines · Arnaldo Carvalho de Melo
perf doesn't use libtracefs and so it doesn't make sense to assume it is always available when building test-all.bin, defeating the feature check speedup it provides.
The other
tools/build/users such as rtla, rv, etc call $(feature_check libtracefs) to check its availability instead of using the test-all.bin mechanism, stopping the build and asking for libtracefs-devel to be installed.Remove it from
FEATURE_TESTS_BASICto not have it as available, as noted by Ian Rogers during review.
Quoted 10 lines
Acked-by Tomas Glozar <[email protected]>Cc Adrian Hunter <[email protected]>Cc Gabriele Monaco <[email protected]>Cc Ian Rogers <[email protected]>Cc James Clark <[email protected]>Cc Jiri Olsa <[email protected]>Cc Kan Liang <[email protected]>Cc Namhyung Kim <[email protected]>Cc Steven Rostedt <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Thanks!
Ian
Quoted 43 lines
--- tools/build/Makefile.feature | 1 - tools/build/feature/test-all.c | 5 ----- 2 files changed, 6 deletions(-)tools/build/Makefile.feature +0
-1@@ -83,7 +83,6 @@ FEATURE_TESTS_BASIC := \ libpython \ libslang \ libtraceevent \ - libtracefs \ libcpupower \ pthread-attr-setaffinity-np \ pthread-barrier \tools/build/feature/test-all.c +0
-6@@ -150,10 +150,6 @@# include "test-libtraceevent.c" #undef main -#define main main_test_libtracefs -# include "test-libtracefs.c" -#undef main -int main (int argc,char *argv[]) {main_test_libpython ();@@ -187,7 +183,6 @@ int main(int argc, char *argv[])main_test_reallocarray ();main_test_libzstd ();main_test_libtraceevent (); -main_test_libtracefs ();return 0 ; } --2.49.0