iommufd: Fix error code in iommu_device_register_bus()
Subsystems (2)
PATCH 1/1 iommufd: Fix error code in iommu_device_register_bus()
This error path accidentally returns success. Return PTR_ERR(iommu->fwnode) instead.
Fixes 885add2e6be6 ("iommufd: Register iommufd mock devices with fwspec")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/iommu.c +1 -1
@@ -330,7 +330,7 @@ int iommu_device_register_bus(struct iommu_device *iommu, iommu->fwnode =fwnode_create_software_node (NULL ,NULL );if (IS_ERR (iommu->fwnode)) {bus_unregister_notifier (bus, nb); -return err; +return PTR_ERR (iommu->fwnode); }spin_lock (&iommu_device_lock);
Signature · 1 line
2.51.0
drivers/iommu/iommu.c int iommu_device_register_bus(struct iommu_device *iommu, · line 334
Quoted 6 lines · Dan Carpenter
drivers/iommu/iommu.c +1
-1iommu->fwnode =fwnode_create_software_node (NULL ,NULL );if (IS_ERR (iommu->fwnode)) {bus_unregister_notifier (bus, nb); -return err; +return PTR_ERR (iommu->fwnode); }
Thanks Dan I fixed the commit
Jason