Skip to contentSkip to conversation

i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware

PATCH Andy Shevchenko 1 participant 1 message Oct 18, 2025 I2C subsystem host drivers

lore
Share & tools
lore

Andy Shevchenko

author Reviewed-by
#0 lore raw
Quoted 4 lines · Jinhui Guo

When probing the I2C master, disable SMBus interrupts to prevent storms caused by broken firmware mis-configuring IC_SMBUS=1; the handler never services them and a mis-configured SMBUS Master extend-clock timeout can flood the CPU.

...

Quoted 4 lines

#define DW_IC_TX_ABRT_SOURCE 0x80
#define DW_IC_ENABLE_STATUS 0x9c
#define DW_IC_CLR_RESTART_DET 0xa8
+#define DW_IC_SMBUS_INTR_MASK 0xcc

It seems one TAB too little.

Quoted 3 lines

#define DW_IC_COMP_PARAM_1 0xf4
#define DW_IC_COMP_VERSION 0xf8
#define DW_IC_SDA_HOLD_MIN_VERS 0x3131312A /* "111*" == v1.11* */

...

The rest LGTM, but let Mika to review.
FWIW,

Signature · 2 lines
With Best Regards,
Andy Shevchenko