Skip to contentSkip to conversation

drm/amdgpu/userqueue: Fix use after free in amdgpu_userq_buffer_vas_list_cleanup()

PATCH Applied Dan Carpenter 2 participants 2 messages Oct 22, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/userqueue: Fix use after free in amdgpu_userq_buffer_vas_list_cleanup()

The amdgpu_userq_buffer_va_list_del() function frees "va_cursor" but it is dereferenced on the next line when we print the debug message. Print the debug message first and then free it.

Fixes 2a28f9665dca ("drm/amdgpu: track the userq bo va for its obj management")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c +1 -1
index 9d4751a39c20..2200e0bbf040 100644
@@ -159,9 +159,9 @@ static int amdgpu_userq_buffer_vas_list_cleanup(struct amdgpu_device *adev,
 			r = -EINVAL;
 			goto err;
 		}
-		amdgpu_userq_buffer_va_list_del(mapping, va_cursor);
 		dev_dbg(adev->dev, "delete the userq:%p va:%llx\n",
 			queue, va_cursor->gpu_addr);
+		amdgpu_userq_buffer_va_list_del(mapping, va_cursor);
 	}
 err:
 	amdgpu_bo_unreserve(queue->vm->root.bo);
Signature · 1 line
2.51.0
Applied
#1 lore raw

Applied. Thanks!

Alex

Quoted 29 lines · Dan Carpenter

The amdgpu_userq_buffer_va_list_del() function frees "va_cursor" but it is dereferenced on the next line when we print the debug message. Print the debug message first and then free it.

Fixes 2a28f9665dca ("drm/amdgpu: track the userq bo va for its obj management")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c +1 -2
index 9d4751a39c20..2200e0bbf040 100644
@@ -159,9 +159,9 @@ static int amdgpu_userq_buffer_vas_list_cleanup(struct amdgpu_device *adev,
                        r = -EINVAL;
                        goto err;
                }
-               amdgpu_userq_buffer_va_list_del(mapping, va_cursor);
                dev_dbg(adev->dev, "delete the userq:%p va:%llx\n",
                        queue, va_cursor->gpu_addr);
+               amdgpu_userq_buffer_va_list_del(mapping, va_cursor);
        }
 err:
        amdgpu_bo_unreserve(queue->vm->root.bo);
--

2.51.0