Skip to contentSkip to conversation

mm/damon/tests/sysfs-kunit: fix use after free on error path

PATCH Applied Dan Carpenter 2 participants 2 messages Nov 21, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/damon/tests/sysfs-kunit: fix use after free on error path

Re-order these frees to avoid dereferencing "sysfs_target" after it has been freed.

Fixes ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")
---
 mm/damon/tests/sysfs-kunit.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/damon/tests/sysfs-kunit.h +1 -1
index ce7218469f20..0c665ed255a3 100644
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test)
 	if (!ctx) {
 		kfree(sysfs_targets->targets_arr);
 		kfree(sysfs_targets);
-		kfree(sysfs_target);
 		kfree(sysfs_target->regions);
+		kfree(sysfs_target);
 		kunit_skip(test, "ctx alloc fail");
 	}
 
Signature · 1 line
2.51.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · On Fri, 21 Nov 2025 16:36:38 +0300 Dan Carpenter <[email protected]>…

Re-order these frees to avoid dereferencing "sysfs_target" after it has been freed.

Thank you for finding and fixing this!

Quoted 3 lines
Fixes ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")

Thanks,
SJ

[...]