staging: rtl8723bs: Rename camel case enumeration
PATCH v3 1/2 staging: rtl8723bs: Rename camel case enumeration
Rename camel case enumeration to snake case and expand enumeration name for clarity. Update indentation of function prototype/definition based on new name length. Move enumeration definition from single line to multi-line definition.
Reported by checkpatch:
CHECK: Avoid CamelCase: <ParseRes>
CHECK: Avoid CamelCase: <ParseFailed>
CHECK: Avoid CamelCase: <ParseUnknown>
CHECK: Avoid CamelCase: <ParseOK>
---
Changes in v3:
- Change parse_result definition to multi-line definition.
- Change parse_res to parse_result for clearer enumeration purpose.
- Update indentation in function prototype/definitions due to name change for parse_result.
Changes in v2:
- Make enumeration constant names all upper case.
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 12 ++++++------ drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 12 ++++++++---- 3 files changed, 15 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +6 -6
@@ -845,9 +845,9 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,* @show_errors: Whether to show parsing errors in debug log * Returns: Parsing result */ -enum ParseRes rtw_ieee802_11_parse_elems (u8 *start,uint len, -struct rtw_ieee802_11_elems *elems, -int show_errors) +enum parse_result rtw_ieee802_11_parse_elems (u8 *start,uint len, +struct rtw_ieee802_11_elems *elems, +int show_errors) {uint left = len;u8 *pos = start;
@@ -863,7 +863,7 @@ enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len, left -=2 ;if (elen > left) -return ParseFailed; +return PARSE_FAILED ;switch (id) {case WLAN_EID_SSID :
@@ -966,9 +966,9 @@ enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len, }if (left) -return ParseFailed; +return PARSE_FAILED ; -return unknown ? ParseUnknown : ParseOK; +return unknown ?PARSE_UNKNOWN :PARSE_OK ; }void rtw_macaddr_cfg (struct device *dev,u8 *mac_addr)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1 -1
@@ -993,7 +993,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame) pstat->capability = capab_info;/* now parse all ieee802_11 ie to point to elems */ -if (rtw_ieee802_11_parse_elems (pos, left, &elems,1 ) == ParseFailed || +if (rtw_ieee802_11_parse_elems (pos, left, &elems,1 ) ==PARSE_FAILED || !elems.ssid) { status =WLAN_STATUS_CHALLENGE_FAIL ; goto OnAssocReqFail;
drivers/staging/rtl8723bs/include/ieee80211.h +8 -4
@@ -724,11 +724,15 @@ struct rtw_ieee802_11_elems {u8 vht_op_mode_notify_len; }; -enum ParseRes { ParseOK =0 , ParseUnknown =1 , ParseFailed =-1 }; +enum parse_result { +PARSE_OK =0 , +PARSE_UNKNOWN =1 , +PARSE_FAILED =-1 +}; -enum ParseRes rtw_ieee802_11_parse_elems (u8 *start,uint len, -struct rtw_ieee802_11_elems *elems, -int show_errors); +enum parse_result rtw_ieee802_11_parse_elems (u8 *start,uint len, +struct rtw_ieee802_11_elems *elems, +int show_errors);u8 *rtw_set_fixed_ie (unsigned char *pbuf,unsigned int len,unsigned char *source,unsigned int *frlen);u8 *rtw_set_ie (u8 *pbuf,signed int index,uint len,u8 *source,uint *frlen);
Signature · 1 line
2.43.0