Skip to contentSkip to conversation

drm/plane: Fix IS_ERR() vs NULL bug drm_plane_create_color_pipeline_property()

PATCH In review Dan Carpenter 2 participants 3 messages Dec 5, 2025 – Dec 11, 2025

Subsystems (3)
DRM drivers DRM misc Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/plane: Fix IS_ERR() vs NULL bug drm_plane_create_color_pipeline_property()

The drm_property_create_enum() function returns NULL on error, it never returns error pointers. Fix the error checking to match.

Fixes 2afc3184f3b3 ("drm/plane: Add COLOR PIPELINE property")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/gpu/drm/drm_plane.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_plane.c +2 -2
index ce76c55913f7..e32c7ea8551c 100644
@@ -1867,9 +1867,9 @@ int drm_plane_create_color_pipeline_property(struct drm_plane *plane,
 	prop = drm_property_create_enum(plane->dev, DRM_MODE_PROP_ATOMIC,
 					"COLOR_PIPELINE",
 					all_pipelines, len);
-	if (IS_ERR(prop)) {
+	if (!prop) {
 		kfree(all_pipelines);
-		return PTR_ERR(prop);
+		return -ENOMEM;
 	}
 
 	drm_object_attach_property(&plane->base, prop, 0);
Signature · 1 line
2.51.0