Skip to contentSkip to conversation

fbdev: omapfb: remove duplicate check in omapfb_setup_mem()

PATCH New Dan Carpenter 1 participant 1 message Jan 8

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: omapfb: remove duplicate check in omapfb_setup_mem()

We know "size" is non-zero because it is checked on the line before. Delete the duplicate check and pull the code in a tab.

---
 drivers/video/fbdev/omap/omapfb_main.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/video/fbdev/omap/omapfb_main.c +4 -6
index 106d21e74738..a8740213e891 100644
@@ -846,12 +846,10 @@ static int omapfb_setup_mem(struct fb_info *fbi, struct omapfb_mem_info *mi)
 		 * be reenabled unless its size is > 0.
 		 */
 		if (old_size != size && size) {
-			if (size) {
-				memcpy(new_var, &fbi->var, sizeof(*new_var));
-				r = set_fb_var(fbi, new_var);
-				if (r < 0)
-					goto out;
-			}
+			memcpy(new_var, &fbi->var, sizeof(*new_var));
+			r = set_fb_var(fbi, new_var);
+			if (r < 0)
+				goto out;
 		}
 
 		if (fbdev->ctrl->sync)
Signature · 1 line
2.51.0