Skip to contentSkip to conversation

scsi: qla2xxx: Completely fix fcport double free

PATCH Applied Vladimir Riabchun 3 participants 5 messages Feb 10 – Mar 11

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: Completely fix fcport double free

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport. Doing it one more time after kref_put is a bad idea.

Fixes 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Fixes 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset")
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_iocb.c +0 -2
index 3224044f1775..0de015de7eb5 100644
@@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (!elsio->u.els_logo.els_logo_pyld) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
@@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (rval != QLA_SUCCESS) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
Signature · 1 line
2.43.0
#2 lore raw
In reply to Vladimir Riabchun

Nilesh,

Quoted 6 lines

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport. Doing it one more time after kref_put is a bad idea.

Please review!

https://lore.kernel.org/all/aYsDln9NFQQsPDgg@vova-pc/

Signature · 1 line
Martin K. Petersen
maintainer
#3 lore raw
In reply to Vladimir Riabchun

From: Vladimir Riabchun <[email protected]>
Sent: Tuesday, February 10, 2026 3:38 PM
To: Nilesh Javali <[email protected]>
Cc: GR-QLogic-Storage-Upstream <[email protected]>; [email protected]; [email protected]; Saurav Kashyap <[email protected]>; [email protected]; Quinn Tran <[email protected]>; [email protected]; [email protected]
Subject: [EXTERNAL] [PATCH] scsi: qla2xxx: Completely fix fcport double free

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference. qla2x00_els_dcmd_sp_free frees fcport by ZjQcmQRYFpfptBannerStart
Prioritize security for external emails:
Confirm sender and content safety before clicking links or opening attachments
  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!s23TuNc6Kf4b28FwlfU2YPVqCLYs7V92y9zVWZhLT6LLyCdQdVjtn_gEpzNAiNXoB4Y$  ‌

ZjQcmQRYFpfptBannerEnd
In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport. Doing it one more time after kref_put is a bad idea.

Fixes 82f522ae0d97 ("scsi: qla2xxx: Fix double free of fcport")
Fixes 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset")
---
 drivers/scsi/qla2xxx/qla_iocb.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/qla2xxx/qla_iocb.c +0 -2
index 3224044f1775..0de015de7eb5 100644
@@ -2751,7 +2751,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (!elsio->u.els_logo.els_logo_pyld) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
@@ -2776,7 +2775,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
 	if (rval != QLA_SUCCESS) {
 		/* ref: INIT */
 		kref_put(&sp->cmd_kref, qla2x00_sp_release);
-		qla2x00_free_fcport(fcport);
 		return QLA_FUNCTION_FAILED;
 	}
 
Signature · 3 lines
2.43.0

Reviewed-by: Nilesh Javali <[email protected]>
#4 lore raw
In reply to Vladimir Riabchun
Quoted 8 lines · Vladimir Riabchun

In qla24xx_els_dcmd_iocb sp->free is set to qla2x00_els_dcmd_sp_free. When an error happens, this function is called by qla2x00_sp_release, when kref_put releases the first and the last reference.

qla2x00_els_dcmd_sp_free frees fcport by calling qla2x00_free_fcport. Doing it one more time after kref_put is a bad idea.

[...]

Applied to 7.0/scsi-fixes, thanks!

[1/1] scsi: qla2xxx: Completely fix fcport double free

      https://git.kernel.org/mkp/scsi/c/c0b7da13a04b
Signature · 1 line
Martin K. Petersen