Skip to contentSkip to conversation

format-patch: fix From header in cover letter

PATCH Mirko Faina 1 participant 1 message Feb 17

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Junio C Hamano

Yes. It does make sense to document the change in thinking in the proposed log message and in documentation.

As I said to Patrick, I don't think anyone would reasonably expect "--from" to not apply to the cover letter as well. Given this, I'm not sure we should refer to this as a change in thinking in the commit message, it should be treated as a bug as if it should've always been this way.

I will edit the documentation to remove any ambiguity.

Thank you