media: i2c: max9286: normalize return value of gpio_get
Subsystems (3)
PATCH 1/1 media: i2c: max9286: normalize return value of gpio_get
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by max9286_gpiochip_get() is normalized to the [0, 1] range.
--- drivers/media/i2c/max9286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/max9286.c +1 -1
@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) {struct max9286_priv *priv =gpiochip_get_data (chip); -return priv->gpio_state &BIT (offset); +return !!(priv->gpio_state &BIT (offset)); }static int max9286_register_gpio (struct max9286_priv *priv)
Signature · 5 lines
2.53.0.335.g19a08e0c02-goog -- Dmitry
Quoted 6 lines · Dmitry Torokhov
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by
max9286_gpiochip_get()is normalized to the [0, 1] range.Signed-off-by Dmitry Torokhov <[email protected]>
Quoted 23 lines
--- drivers/media/i2c/max9286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/max9286.c +1
-2@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) {struct max9286_priv *priv =gpiochip_get_data (chip); -return priv->gpio_state &BIT (offset); +return !!(priv->gpio_state &BIT (offset)); }static int max9286_register_gpio (struct max9286_priv *priv) --2.53.0.335.g19a08e0c02-goog
--
Dmitry
Signature · 1 line
Ricardo Ribalda
Quoted 26 lines · Dmitry Torokhov
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by
max9286_gpiochip_get()is normalized to the [0, 1] range.Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/media/i2c/max9286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/max9286.c +1
-2@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) {struct max9286_priv *priv =gpiochip_get_data (chip); -return priv->gpio_state &BIT (offset); +return !!(priv->gpio_state &BIT (offset)); }static int max9286_register_gpio (struct max9286_priv *priv) --2.53.0.335.g19a08e0c02-goog
Quoted 3 lines
--
Dmitry
Quoting Dmitry Torokhov (2026-02-18 20:53:48)
Quoted 14 lines
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by
max9286_gpiochip_get()is normalized to the [0, 1] range.Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/media/i2c/max9286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/max9286.c +0
-0
drivers/media/i2c/max9286.c static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) · line 1208
Quoted 5 lines
drivers/media/i2c/max9286.c +1
-1@@ -1205,7 +1205,7 @@ static int max9286_gpiochip_get(struct gpio_chip *chip, unsigned int offset) {struct max9286_priv *priv =gpiochip_get_data (chip); -return priv->gpio_state &BIT (offset); +return !!(priv->gpio_state &BIT (offset));
Quoted 9 lines
drivers/media/i2c/max9286.c +0
-0}static int max9286_register_gpio (struct max9286_priv *priv)Signature · 5 lines
2.53.0.335.g19a08e0c02-goog -- Dmitry
Quoted 5 lines · Dmitry Torokhov
The GPIO get callback is expected to return 0 or 1 (or a negative error code). Ensure that the value returned by
max9286_gpiochip_get()is normalized to the [0, 1] range.Signed-off-by Dmitry Torokhov <[email protected]>
Yours,
Linus Walleij