Skip to contentSkip to conversation

staging: greybus: document codec mutex usage

PATCH In review Bartłomiej Konecki 2 participants 2 messages Feb 19

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: document codec mutex usage

Add comments describing lock and register_mutex
in struct gbaudio_codec_info.
The lock protects the codec runtime state and module/DAI lists, while register_mutex protects hardware registers.
Improve readability and clarify locking semantics.

---
 drivers/staging/greybus/audio_codec.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/greybus/audio_codec.h +2 -1
index f3f7a7ec6be4..90dd3426d4a4 100644
@@ -70,8 +70,9 @@ struct gbaudio_codec_info {
 	struct list_head module_list;
 	/* to maintain runtime stream params for each DAI */
 	struct list_head dai_list;
-	struct mutex lock;
+	struct mutex lock;	/* protects codec state and module/DAI lists */
 	struct mutex register_mutex;
+	/* serializes access to codec hardware registers*/
 };
 
 struct gbaudio_widget {
Signature · 1 line
2.47.3
#1 lore raw
Quoted 16 lines · Bartłomiej Konecki

Add comments describing lock and register_mutex
in struct gbaudio_codec_info.
The lock protects the codec runtime state and module/DAI lists, while register_mutex protects hardware registers.
Improve readability and clarify locking semantics.

---
 drivers/staging/greybus/audio_codec.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/greybus/audio_codec.h +0 -0
index f3f7a7ec6be4..90dd3426d4a4 100644

drivers/staging/greybus/audio_codec.h struct gbaudio_codec_info { · line 75

Quoted 7 lines
drivers/staging/greybus/audio_codec.h +2 -1
@@ -70,8 +70,9 @@ struct gbaudio_codec_info {
 	struct list_head module_list;
 	/* to maintain runtime stream params for each DAI */
 	struct list_head dai_list;
-	struct mutex lock;
+	struct mutex lock;	/* protects codec state and module/DAI lists */
 	struct mutex register_mutex;
+	/* serializes access to codec hardware registers*/

No, it doesn't.

regards,
dan carpenter