Skip to contentSkip to conversation

ARM: dts: Aspeed: witherspoon-128: Remove checkstop GPIO from gpio-keys

PATCH In review bentyner 2 participants 2 messages Apr 8, 2020 – Apr 10, 2020

Subsystems (2)
lore
Share & tools
lore

bentyner

author
#0 lore raw

PATCH 1/1 ARM: dts: Aspeed: witherspoon-128: Remove checkstop GPIO from gpio-keys

Attention handler will monitor the checkstop gpio via the character device interface so it needs to not be defined.

---
 .../dts/aspeed-bmc-opp-witherspoon-128.dts    | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts +40 -0
index 1ba673a49334..701d58b7f0dc 100644
@@ -4,6 +4,46 @@
 
 #include "aspeed-bmc-opp-witherspoon.dts"
 
+/ {
+	gpio-keys {
+		/delete-node/ checkstop;
+	};
+};
+
+&gpio {
+	gpio-line-names =
+	/*A0-A7*/	"","cfam-reset","","","","","fsi-mux","",
+	/*B0-B7*/	"","","","","","air-water","","",
+	/*C0-C7*/	"","","","","","","","",
+	/*D0-D7*/	"fsi-enable","","","","","","","",
+	/*E0-E7*/	"fsi-data","","","","","","","",
+	/*F0-F7*/	"","","","","","","","",
+	/*G0-G7*/	"","","","","","","","",
+	/*H0-H7*/	"","","","","","","","",
+	/*I0-I7*/	"","","","","","","","",
+	/*J0-J7*/	"","","","","","","","",
+	/*K0-K7*/	"","","","","","","","",
+	/*L0-L7*/	"","","","","","","","",
+	/*M0-M7*/	"","","","","","","","",
+	/*N0-N7*/	"presence-ps1","","led-rear-fault","led-rear-power",
+		        "led-rear-id","","","",
+	/*O0-O7*/	"","","","","","","","",
+	/*P0-P7*/	"","","","","","","","presence-ps0",
+	/*Q0-Q7*/	"","","","","","","","",
+	/*R0-R7*/	"","","fsi-trans","","","power-button","","",
+	/*S0-S7*/	"","","","","","","","",
+	/*T0-T7*/	"","","","","","","","",
+	/*U0-U7*/	"","","","","","","","",
+	/*V0-V7*/	"","","","","","","","",
+	/*W0-W7*/	"","","","","","","","",
+	/*X0-X7*/	"","","","","","","","",
+	/*Y0-Y7*/	"","","","","","","","",
+	/*Z0-Z7*/	"","","","","","","","",
+	/*AA0-AA7*/	"fsi-clock","","","","","","","",
+	/*AB0-AB7*/	"","","","","","","","",
+	/*AC0-AC7*/	"","","","","","","","";
+};
+
 &fmc {
 	status = "okay";
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 14 lines · bentyner

Attention handler will monitor the checkstop gpio via the character device interface so it needs to not be defined.

---
  .../dts/aspeed-bmc-opp-witherspoon-128.dts    | 40 +++++++++++++++++++
  1 file changed, 40 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts +0 -0
index 1ba673a49334..701d58b7f0dc 100644

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts line 11

Quoted 8 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts +5 -0
@@ -4,6 +4,46 @@
 
  #include "aspeed-bmc-opp-witherspoon.dts"
 
+/ {
+	gpio-keys {
+		/delete-node/ checkstop;
+	};
+};

Is this literally just for witherspoon-128 or is it meant to be a generic change to witherspoon behaviour? The answer should be added to the commit message if this is specific to witherspoon-128 (and probably talk about why it's not necessary for witherspoon).

Quoted 24 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts +24 -0
+
+&gpio {
+	gpio-line-names =
+	/*A0-A7*/	"","cfam-reset","","","","","fsi-mux","",
+	/*B0-B7*/	"","","","","","air-water","","",
+	/*C0-C7*/	"","","","","","","","",
+	/*D0-D7*/	"fsi-enable","","","","","","","",
+	/*E0-E7*/	"fsi-data","","","","","","","",
+	/*F0-F7*/	"","","","","","","","",
+	/*G0-G7*/	"","","","","","","","",
+	/*H0-H7*/	"","","","","","","","",
+	/*I0-I7*/	"","","","","","","","",
+	/*J0-J7*/	"","","","","","","","",
+	/*K0-K7*/	"","","","","","","","",
+	/*L0-L7*/	"","","","","","","","",
+	/*M0-M7*/	"","","","","","","","",
+	/*N0-N7*/	"presence-ps1","","led-rear-fault","led-rear-power",
+		        "led-rear-id","","","",
+	/*O0-O7*/	"","","","","","","","",
+	/*P0-P7*/	"","","","","","","","presence-ps0",
+	/*Q0-Q7*/	"","","","","","","","",
+	/*R0-R7*/	"","","fsi-trans","","","power-button","","",
+	/*S0-S7*/	"","","","","","","","",
+	/*T0-T7*/	"","","","","","","","",

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts line 45

Quoted 10 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon-128.dts +10 -0
+	/*U0-U7*/	"","","","","","","","",
+	/*V0-V7*/	"","","","","","","","",
+	/*W0-W7*/	"","","","","","","","",
+	/*X0-X7*/	"","","","","","","","",
+	/*Y0-Y7*/	"","","","","","","","",
+	/*Z0-Z7*/	"","","","","","","","",
+	/*AA0-AA7*/	"fsi-clock","","","","","","","",
+	/*AB0-AB7*/	"","","","","","","","",
+	/*AC0-AC7*/	"","","","","","","","";
+};

I don't see that the checkstop gpio line is named here and so I don't think it's a relevant change?

Why is it necessary in this patch?

Andrew