Skip to contentSkip to conversation

generic/746: install two necessary files

PATCH In review An Long 2 participants 4 messages Oct 10, 2024 Btrfs file system

lore
Share & tools
lore

An Long

author
#0 lore raw

PATCH v3 1/1 generic/746: install two necessary files

parse-dev-tree.awk and parse-extent-tree.awk are used by generic/746. We need to make sure them are installed, otherwise generic/746 will have problems if fstests is installed via "make install".

---
 src/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/Makefile +1 -1
index 3097c29e..a0396332 100644
@@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
 
 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
              btrfs_crc32c_forged_name.py popdir.pl popattr.py \
-             soak_duration.awk
+             soak_duration.awk parse-dev-tree.awk parse-extent-tree.awk
 
 SUBDIRS = log-writes perf
 
Signature · 1 line
2.43.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 6 lines · An Long

parse-dev-tree.awk and parse-extent-tree.awk are used by generic/746. We need to make sure them are installed, otherwise generic/746 will have problems if fstests is installed via "make install".

---

Thanks for fixing it, most of people run fstests directly after building, we need to take care the install list too.

Quoted 20 lines
 src/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/Makefile +1 -1
index 3097c29e..a0396332 100644
@@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
 
 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
              btrfs_crc32c_forged_name.py popdir.pl popattr.py \
-             soak_duration.awk
+             soak_duration.awk parse-dev-tree.awk parse-extent-tree.awk
 
 SUBDIRS = log-writes perf
 
Signature · 1 line
2.43.0
#2 lore raw
In reply to An Long
Quoted 6 lines · An Long

parse-dev-tree.awk and parse-extent-tree.awk are used by generic/746. We need to make sure them are installed, otherwise generic/746 will have problems if fstests is installed via "make install".

---

There might be something (format) wrong when you generated or sent this patch, I can't merge it directly, the git am shows:

Applying: generic/746: install two necessary files
error: corrupt patch at line 18
Patch failed at 0001 generic/746: install two necessary files
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Anyway, this change is simple enough, so I've maken this change manually (with author=$you), so don't need to send one more version, just remind it.

Thanks,
Zorro

Quoted 20 lines
 src/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/Makefile +1 -1
index 3097c29e..a0396332 100644
@@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
 
 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
              btrfs_crc32c_forged_name.py popdir.pl popattr.py \
-             soak_duration.awk
+             soak_duration.awk parse-dev-tree.awk parse-extent-tree.awk
 
 SUBDIRS = log-writes perf
 
Signature · 1 line
2.43.0
author
#3 lore raw
Quoted 26 lines · Zorro Lang
Quoted 7 lines · An Long

parse-dev-tree.awk and parse-extent-tree.awk are used by generic/746.
We need to make sure them are installed, otherwise generic/746 will have problems if fstests is installed via "make install".

---

There might be something (format) wrong when you generated or sent this
patch, I can't merge it directly, the git am shows:

  Applying: generic/746: install two necessary files
  error: corrupt patch at line 18
  Patch failed at 0001 generic/746: install two necessary files
  hint: Use 'git am --show-current-patch=diff' to see the failed patch
  hint: When you have resolved this problem, run "git am --continue".
  hint: If you prefer to skip this patch, run "git am --skip" instead.
  hint: To restore the original branch and stop patching, run "git am --abort".
  hint: Disable this message with "git config advice.mergeConflict false"

Quoted 7 lines

Anyway, this change is simple enough, so I've maken this change manually
(with author=$you), so don't need to send one more version, just remind it.

Thanks,
Zorro

Thank you, Lang! I've double checked, there is a "=20"(space) in the end of mail. However, I'll ensure the format is correct next time.

Quoted 25 lines
Quoted 24 lines

 src/Makefile | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
src/Makefile +0 -0
index 3097c29e..a0396332 100644
@@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize
 preallo_rw_pattern_reader \
 

 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
              btrfs_crc32c_forged_name.py popdir.pl popattr.py \
-             soak_duration.awk
+             soak_duration.awk parse-dev-tree.awk parse-extent- tree.awk

 SUBDIRS = log-writes perf

Signature · 1 line
2.43.0
Signature · 2 lines
An Long <[email protected]>
SUSE QE LSG, QE 2, Beijing