Skip to contentSkip to conversation

linux-next: build failure after merge of the xen-tip tree

DISCUSSION Mark Brown 2 participants 2 messages Mar 4 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

After merging the xen-tip tree, today's linux-next build (x86_64 allmodconfig) failed like this:

In file included from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:38,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/amdgpu.h:56,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c:29:
/tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hw_types.h:221:6: error: 'pixel_format' defined as wrong kind of tag

  221 | enum pixel_format {
      |      ^~~~~~~~~~~~

Caused (I think) by commit

4e05a08c6f3f3 (ACPI, x86/boot: Remove {set|get}_root_pointer() ACPI callbacks)

which changes the inclusions and I think triggers namespace clashes with the unnamespaced pixel_format. I've used the tree from next-20260303 instead but really the fix here is that amdgpu and other things defining a pixel_format should namespace things, I'll consider if a revert is more sensible.

#1 lore raw
Quoted 16 lines · Mark Brown

Hi all,

After merging the xen-tip tree, today's linux-next build (x86_64 allmodconfig) failed like this:

In file included from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:38,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30, from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/../include/dm_pp_interface.h:26,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/amdgpu.h:56,
from /tmp/next/build/drivers/gpu/drm/amd/amdgpu/atombios_crtc.c:29:
/tmp/next/build/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_hw_types.h:221:6: error: 'pixel_format' defined as wrong kind of tag

   221 | enum pixel_format {
       |      ^~~~~~~~~~~~

Caused (I think) by commit

Quoted 7 lines
   4e05a08c6f3f3 (ACPI, x86/boot: Remove {set|get}_root_pointer() ACPI callbacks)

which changes the inclusions and I think triggers namespace clashes with the unnamespaced pixel_format. I've used the tree from next-20260303 instead but really the fix here is that amdgpu and other things defining a pixel_format should namespace things, I'll consider if a revert is more sensible.

For now I have removed 4e05a08c6f3f3 from the Xen tree.

Juergen