Skip to contentSkip to conversation

Missing signoff in the rpmsg tree

DISCUSSION Mark Brown 2 participants 6 messages Mar 6 – Apr 14 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Commits

390045a24591a ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP") 0af8802175d2d ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP")

are missing a Signed-off-by from their committers

author maintainer
#1 lore raw
Quoted 6 lines · Mark Brown

Commits

390045a24591a ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP") 0af8802175d2d ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP")

are missing a Signed-off-by from their committers

This issue is still present today.

author maintainer
#2 lore raw
Quoted 9 lines · Mark Brown
Quoted 6 lines · Mark Brown

Commits

390045a24591a ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP") 0af8802175d2d ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP")

are missing a Signed-off-by from their committers

This issue is still present today.

And today.

author maintainer
#3 lore raw
Quoted 4 lines · Mark Brown
Quoted 3 lines · Mark Brown
Quoted 2 lines · Mark Brown

Commits

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

390045a24591a ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP") 0af8802175d2d ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP")

are missing a Signed-off-by from their committers

This issue is still present today.

And today.

Today also.

#4 lore raw
In reply to Mark Brown
Quoted 6 lines · Mark Brown

Commits

390045a24591a ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP") 0af8802175d2d ("dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP")

are missing a Signed-off-by from their committers

Sorry, missed this thread in the inbox noise.

It looks like Mathieu rebased across the two commits and hence ended up as committer. Fixing it would imply rebasing a bunch of commits, in which I would have to add my s-o-b to patches applied by Mathieu.

I'd suggest that we ignore the issue this time. Let me know if you think otherwise.

PS. It would be nice if checkpatch caught these. I tried to teach it a while back, but the reviews fell through due to my lacking perl abilities.

Regards,
Bjorn

author maintainer
#5 lore raw
Quoted 6 lines · Bjorn Andersson

It looks like Mathieu rebased across the two commits and hence ended up as committer. Fixing it would imply rebasing a bunch of commits, in which I would have to add my s-o-b to patches applied by Mathieu.

I'd suggest that we ignore the issue this time. Let me know if you think otherwise.

That's a question for Linus not me.