Skip to contentSkip to conversation

scripts/checkpatch.pl refers to non-existent Documentation/Documentation/volatile-considered-harmful.txt

DISCUSSION Roland Dreier 4 participants 4 messages Jun 20, 2007 – Jun 23, 2007

lore
Share & tools
lore
#0 lore raw

Commit 4a0df2ef added the following to scripts/checkpatch.pl:

    print "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n";

but Linus's tree has no such file. not sure what the right thing to do here is, since I assume we do ultimately want something of the sort in Documentation...

- R.

#1 lore raw
Quoted 8 lines · Roland Dreier

Commit 4a0df2ef added the following to scripts/checkpatch.pl:

    print "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n";

but Linus's tree has no such file. not sure what the right thing to do here is, since I assume we do ultimately want something of the sort in Documentation...

That document is in the -mm kernel currently. As soon as it hits mainline from there checkpatch.pl will be right :-)

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#2 lore raw
Quoted 6 lines · On Wed, 20 Jun 2007 23:03:44 +0200 "Jesper Juhl" <[email protected]> wrote:
Quoted 4 lines · Roland Dreier

Commit 4a0df2ef added the following to scripts/checkpatch.pl:

    print "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n";
Quoted 8 lines
Quoted 4 lines

but Linus's tree has no such file. not sure what the right thing to do here is, since I assume we do ultimately want something of the sort in Documentation...

That document is in the -mm kernel currently. As soon as it hits mainline from there checkpatch.pl will be right :-)

oops. I queued volatile-considered-harmful-take-3.patch for 2.6.22, thanks.

#3 lore raw
In reply to Roland Dreier
Quoted 7 lines · Roland Dreier

Commit 4a0df2ef added the following to scripts/checkpatch.pl:

    print "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n";

but Linus's tree has no such file. not sure what the right thing to do here is, since I assume we do ultimately want something of the sort in Documentation...

That is a little unfortuanate for sure. As Jasper correctly indicates this file is coming soon to a linus tree near you and things will be accurate. Otherwise it can be obtained from the current -mm tarball. It can also be found here on LWN:

	http://lwn.net/Articles/234017/

-apw