ehea: Access iph->tot_len with correct endianness
Subsystems (2)
PATCH 1/1 ehea: Access iph->tot_len with correct endianness
iph->tot_len is stored in network byte order, so access it using ntohs(). This doesn't have any real world impact on ehea, since ehea only exists for big-endian platfroms (at the moment at least) but fixing this gets rid of a sparse warning and avoids having a bad example in the tree.
--- drivers/net/ehea/ehea_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ehea/ehea_main.c +1 -1
@@ -616,7 +616,7 @@ static int get_skb_hdr(struct sk_buff *skb, void **iphdr, *tcph =tcp_hdr (skb);/* check if ip header and tcp header are complete */ -if (iph->tot_len < ip_len +tcp_hdrlen (skb)) +if (ntohs (iph->tot_len) < ip_len +tcp_hdrlen (skb))return -1 ; *hdr_flags =LRO_IPV4 |LRO_TCP ;
Quoted 25 lines · Roland Dreier
iph->tot_lenis stored in network byte order, so access it usingntohs(). This doesn't have any real world impact on ehea, since ehea only exists for big-endian platfroms (at the moment at least) but fixing this gets rid of a sparse warning and avoids having a bad example in the tree.Signed-off-by Roland Dreier <[email protected]>--- drivers/net/ehea/ehea_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/ehea/ehea_main.c +1
-2@@ -616,7 +616,7 @@ static int get_skb_hdr(struct sk_buff *skb, void **iphdr, *tcph =tcp_hdr (skb);/* check if ip header and tcp header are complete */ -if (iph->tot_len < ip_len +tcp_hdrlen (skb)) +if (ntohs (iph->tot_len) < ip_len +tcp_hdrlen (skb))return -1 ; *hdr_flags =LRO_IPV4 |LRO_TCP ; --
Quoted 3 lines
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Correct. Thanks Roland!
Jeff Garzik
AppliedQuoted 10 lines · Roland Dreier
iph->tot_lenis stored in network byte order, so access it usingntohs(). This doesn't have any real world impact on ehea, since ehea only exists for big-endian platfroms (at the moment at least) but fixing this gets rid of a sparse warning and avoids having a bad example in the tree.Signed-off-by Roland Dreier <[email protected]>--- drivers/net/ehea/ehea_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
applied this and pasemi_mac patch to 2.6.26.