Skip to contentSkip to conversation

enic: Fix Kconfig headline description

PATCH Applied Roland Dreier 3 participants 5 messages Oct 13, 2008 – Oct 27, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 enic: Fix Kconfig headline description

From: Scott Feldman <[email protected]>

I don't think the enic driver has anything to do with Mark Everett
(http://en.wikipedia.org/wiki/A_Man_Called_E). Fix the Kconfig description.

---
And this is the other half of
https://kerneltrap.org/mailarchive/linux-netdev/2008/9/20/3350614/thread
that seems to have gotten dropped. Please apply.

 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/Kconfig +1 -1
index e9d5294..1d8af33 100644
@@ -2400,7 +2400,7 @@ config EHEA
 	  will be called ehea.
 
 config ENIC
-	tristate "E, the Cisco 10G Ethernet NIC"
+	tristate "Cisco 10G Ethernet NIC support"
 	depends on PCI && INET
 	select INET_LRO
 	help
#2 lore raw
In reply to Roland Dreier
Quoted 20 lines · Roland Dreier

From: Scott Feldman <[email protected]>

I don't think the enic driver has anything to do with Mark Everett
(http://en.wikipedia.org/wiki/A_Man_Called_E). Fix the Kconfig description.

---
And this is the other half of
https://kerneltrap.org/mailarchive/linux-netdev/2008/9/20/3350614/thread
that seems to have gotten dropped. Please apply.

 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/Kconfig +0 -0
index e9d5294..1d8af33 100644

drivers/net/Kconfig config EHEA · line 2404

Quoted 6 lines
drivers/net/Kconfig +1 -1
@@ -2400,7 +2400,7 @@ config EHEA
 	  will be called ehea.
 
 config ENIC
-	tristate "E, the Cisco 10G Ethernet NIC"
+	tristate "Cisco 10G Ethernet NIC support"
 	depends on PCI && INET

Sheesh, Cisco just does not have any sense of humor :)

As I explained to Scott (in private email, unfortunately, IIRC), I did that so that it would fit in the list alphabetized -- Scott placed it in the section with the E's, not the C's.

Furthermore, "Cisco 10G ethernet nic" is a vague description if Cisco ever plans to sell another ethernet product. Will the next one be "Cisco 10G Ethernet NIC, the sequel"? :)

If you insist on such an incredibly boring description, at least put it into the section with the 'C' not the 'E'.

Jeff

#3 lore raw
Quoted 1 line

Sheesh, Cisco just does not have any sense of humor :)

Hey I thought name-checking Mark Everett in the changelog was kind of funny.

Quoted 3 lines

As I explained to Scott (in private email, unfortunately, IIRC), I did that so that it would fit in the list alphabetized -- Scott placed it in the section with the E's, not the C's.

Unfortunately Dave already applied my patch (and somehow dropped the "From: Scott" part of my email so I get blamed ;). I didn't realize the list was alphabetized -- I guess we should add another patch to put this in the right place in the list?

Quoted 3 lines

Furthermore, "Cisco 10G ethernet nic" is a vague description if Cisco ever plans to sell another ethernet product. Will the next one be "Cisco 10G Ethernet NIC, the sequel"? :)

I guess we're just counting on being on to 100G ethernet by the time we do another NIC... but seriously we should probably figure out what the marketing name will be and improve the help text.

- R.

#4 lore raw
Quoted 4 lines · Roland Dreier
Quoted 1 line

Sheesh, Cisco just does not have any sense of humor :)

Hey I thought name-checking Mark Everett in the changelog was kind of funny.

Quoted 8 lines
Quoted 3 lines

As I explained to Scott (in private email, unfortunately, IIRC), I did that so that it would fit in the list alphabetized -- Scott placed it in the section with the E's, not the C's.

Unfortunately Dave already applied my patch (and somehow dropped the "From: Scott" part of my email so I get blamed ;). I didn't realize the list was alphabetized -- I guess we should add another patch to put this in the right place in the list?

Low priority, but, yes please.

Jeff