Skip to contentSkip to conversation

ACPI: Get rid of "registered as cooling_deviceX" messages

PATCH New Roland Dreier 1 participant 1 message Sep 28, 2009 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: Get rid of "registered as cooling_deviceX" messages

The messages "<xyz> registered as cooling_deviceX" printed by various ACPI drivers give the same information as just looking at the symlinks /sys/class/thermal/cooling_deviceX/device. On a big system, they clutter up the syslog and take a long time to print on a serial console.

On a 64-thread system I've been lucky enough to play with:

    $ dmesg | grep 'registered as cooling_device' | wc
         64     448    4278

which is getting past tragedy and into the realm of comedy. We may as well not print these messages.

---
Len, still more in my trimming of the boot log on my big box. If this makes sense to you, please apply.

Also I think <http://patchwork.kernel.org/patch/50048/> might have gotten lost somewhere -- you applied the C-state version but not the equivalent T-state patch.

 drivers/acpi/fan.c            |    2 --
 drivers/acpi/processor_core.c |    3 ---
 drivers/acpi/video.c          |    2 --
 3 files changed, 0 insertions(+), 7 deletions(-)
drivers/acpi/fan.c +0 -2
index f419849..6bbc61d 100644
@@ -267,8 +267,6 @@ static int acpi_fan_add(struct acpi_device *device)
 		goto end;
 	}
 
-	dev_info(&device->dev, "registered as cooling_device%d\n", cdev->id);
-
 	device->driver_data = cdev;
 	result = sysfs_create_link(&device->dev.kobj,
 				   &cdev->device.kobj,
drivers/acpi/processor_core.c +0 -3
index c2d4d6e..3d6e95e 100644
@@ -845,9 +845,6 @@ static int acpi_processor_add(struct acpi_device *device)
 		goto err_power_exit;
 	}
 
-	dev_info(&device->dev, "registered as cooling_device%d\n",
-		 pr->cdev->id);
-
 	result = sysfs_create_link(&device->dev.kobj,
 				   &pr->cdev->device.kobj,
 				   "thermal_cooling");
drivers/acpi/video.c +0 -2
index a4fddb2..3f67f4d 100644
@@ -1022,8 +1022,6 @@ static void acpi_video_device_find_cap(struct acpi_video_device *device)
 			return;
 		}
 
-		dev_info(&device->dev->dev, "registered as cooling_device%d\n",
-			 device->cooling_dev->id);
 		result = sysfs_create_link(&device->dev->dev.kobj,
 				&device->cooling_dev->device.kobj,
 				"thermal_cooling");