Skip to contentSkip to conversation

Add MODULE_DEVICE_TABLE() so ioatdma module is autoloaded

PATCH In review Roland Dreier 2 participants 2 messages Jul 1, 2009 – Jul 2, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add MODULE_DEVICE_TABLE() so ioatdma module is autoloaded

The ioatdma module is missing aliases for the PCI devices it supports, so it is not autoloaded on boot. Add a MODULE_DEVICE_TABLE() to get these aliases.

---
Not sure if not autoloading was intentional or if it's just an oversight, but this patch seems useful to me, so please apply if it makes sense to you.

 drivers/dma/ioat.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/dma/ioat.c +2 -0
index 2225bb6..a1d8b8d 100644
@@ -60,6 +60,8 @@ static struct pci_device_id ioat_pci_tbl[] = {
 	{ 0, }
 };
 
+MODULE_DEVICE_TABLE(pci, ioat_pci_tbl);
+
 struct ioat_device {
 	struct pci_dev		*pdev;
 	void __iomem		*iobase;
#1 lore raw
Quoted 10 lines · Roland Dreier

The ioatdma module is missing aliases for the PCI devices it supports, so it is not autoloaded on boot.  Add a MODULE_DEVICE_TABLE() to get these aliases.

---
Not sure if not autoloading was intentional or if it's just an oversight, but this patch seems useful to me, so please apply if it makes sense to you.

Makes sense. I believe the only hesitation is that it is a bit awkward to remove (ifdown all interfaces, stop all raid456 arrays). However, unless Maciej disagrees I think we should go ahead and autoload it.

Applied for now to the 'fixes' branch of async_tx.git.

Thanks,
Dan