Skip to contentSkip to conversation

checkkconfigsymbols.sh: Kconfig symbols sometimes have lowercase letters

PATCH New Roland Dreier 1 participant 1 message Jun 2, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkkconfigsymbols.sh: Kconfig symbols sometimes have lowercase letters

Quite a few Kconfig symbols contain lowercase letters. The current checkkconfigsymbols.sh code only contains A-Z in the regexp it uses to find config symbols in source code, so it comes up with the wrong symbol to look for in Kconfig files and then generates false positives when it doesn't find that wrong symbol. For example checking drivers/net generates a false positive for MAC89 because the the actual config option is MAC89x0.

Fix this by also adding a-z to the regexp.

---
 scripts/checkkconfigsymbols.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/checkkconfigsymbols.sh +1 -1
index 46be3c5..2ca49bb 100755
@@ -14,7 +14,7 @@ find $paths -name '*.[chS]' -o -name 'Makefile' -o -name 'Makefile*[^~]'| while
 do
 	# Output the bare Kconfig variable and the filename; the _MODULE part at
 	# the end is not removed here (would need perl an not-hungry regexp for that).
-	sed -ne 's!^.*\<\(UML_\)\?CONFIG_\([0-9A-Z_]\+\).*!\2 '$i'!p' < $i
+	sed -ne 's!^.*\<\(UML_\)\?CONFIG_\([0-9A-Za-z_]\+\).*!\2 '$i'!p' < $i
 done | \
 # Smart "sort|uniq" implemented in awk and tuned to collect the names of all
 # files which use a given symbol
Signature · 2 lines
Roland Dreier <[email protected]> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html