Skip to contentSkip to conversation

x86emul: increase FPU save area in test harness/fuzzer

PATCH In review Jan Beulich 2 participants 2 messages Oct 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86emul: increase FPU save area in test harness/fuzzer

Running them on a system (or emulator) with AMX support requires this to be quite a bit larger than 8k, to avoid triggering the assert() in emul_test_init(). Bump all the way up to 16k right away.

---
Intel's Software Development Emulator properly reports XSAVE-related AMX CPUID data for Sapphire Rapids emulation as of 8.59.0.

tools/tests/x86_emulator/x86-emulate.c +1 -1
@@ -33,7 +33,7 @@
 uint32_t mxcsr_mask = 0x0000ffbf;
 struct cpuid_policy cp;
 
-static char fpu_save_area[4096] __attribute__((__aligned__((64))));
+static char fpu_save_area[0x4000] __attribute__((__aligned__((64))));
 static bool use_xsave;
 
 /*
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jan Beulich

Running them on a system (or emulator) with AMX support requires this to be quite a bit larger than 8k, to avoid triggering the assert() in emul_test_init(). Bump all the way up to 16k right away.

Quoted 15 lines

---
Intel's Software Development Emulator properly reports XSAVE-related AMX CPUID data for Sapphire Rapids emulation as of 8.59.0.

tools/tests/x86_emulator/x86-emulate.c +1 -1
@@ -33,7 +33,7 @@
 uint32_t mxcsr_mask = 0x0000ffbf;
 struct cpuid_policy cp;
 
-static char fpu_save_area[4096] __attribute__((__aligned__((64))));
+static char fpu_save_area[0x4000] __attribute__((__aligned__((64))));
 static bool use_xsave;
 
 /*