drm/panel: himax-hx83121a: Fix NULL vs IS_ERR() check in probe()
Subsystems (4)
PATCH 1/1 drm/panel: himax-hx83121a: Fix NULL vs IS_ERR() check in probe()
The devm_drm_panel_alloc() function never returns NULL, it returns error pointers on failure.
Fixes a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
Signed-off-by Dan Carpenter <[email protected]>
---
This email is a free service from the Smatch-CI project [smatch.sf.net].
drivers/gpu/drm/panel/panel-himax-hx83121a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/panel/panel-himax-hx83121a.c +2 -2
@@ -596,8 +596,8 @@ static int himax_probe(struct mipi_dsi_device *dsi) ctx = devm_drm_panel_alloc(dev, struct himax, panel, &himax_panel_funcs,DRM_MODE_CONNECTOR_DSI ); -if (!ctx) -return -ENOMEM ; +if (IS_ERR (ctx)) +return PTR_ERR (ctx); ret = devm_regulator_bulk_get_const(&dsi->dev, ARRAY_SIZE(himax_supplies),
Signature · 1 line
2.53.0
Quoted 7 lines · Dan Carpenter
The
devm_drm_panel_alloc()function never returns NULL, it returns error pointers on failure.Fixes a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")Signed-off-by Dan Carpenter <[email protected]>---
Sorry, Chen Ni had sent it.
https://lore.kernel.org/dri-devel/[email protected]/
--
Pengyu