Skip to contentSkip to conversation

matroxfb dies when you try to use secondary head in 2.5.x

PATCH New Petr Vandrovec 1 participant 1 message Jun 8, 2002 Framebuffer layer

lore
Share & tools
lore

Petr Vandrovec

author
#0 lore raw

PATCH 1/1 matroxfb dies when you try to use secondary head in 2.5.x

Hi Linus,
please apply this to 2.5.20. James introduced bad bug which
causes NULL pointer dereference as soon as you'll try to use secondary head because of screen_base is not initialized (it is initialized on wrong head).
Thanks,
Petr Vandrovec [email protected]

drivers/video/matrox/matroxfb_crtc2.c +1 -1
diff -urdN linux/drivers/video/matrox/matroxfb_crtc2.c linux/drivers/video/matrox/matroxfb_crtc2.c
@@ -383,7 +383,7 @@
 		chgvar = 0;
 	p->var = *var;
 	/* cmap */
-	ACCESS_FBINFO(fbcon.screen_base) = vaddr_va(m2info->video.vbase);
+	m2info->fbcon.screen_base = vaddr_va(m2info->video.vbase);
 	p->visual = visual;
 	p->ypanstep = 1;
 	p->ywrapstep = 0;

_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas - http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink