Skip to contentSkip to conversation

arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support

PATCH Alexander Koskovich 3 participants 3 messages Apr 13 – Apr 20 Arm Qualcomm mailing list

lore
Share & tools
lore

Alexander Koskovich

author
#0 lore raw
Quoted 18 lines · Abel Vesa

The Eliza MTP features a single USB Type-C port. Its USB 2.0 lines are routed through an eUSB2 repeater provided by the PM7750BA PMIC.

Describe the port and repeater, and enable the USB controller and PHYs.

Also specify the ADSP firmware and enable the remoteproc.

Signed-off-by Abel Vesa <[email protected]>
---
 arch/arm64/boot/dts/qcom/eliza-mtp.dts | 83 ++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
arch/arm64/boot/dts/qcom/eliza-mtp.dts +0 -0
index 90f629800cb0..c31f00e36eee 100644
@@ -6,9 +6,12 @@
 /dts-v1/;

...

arch/arm64/boot/dts/qcom/eliza-mtp.dts

Quoted 3 lines

+&usb_hsphy {

arch/arm64/boot/dts/qcom/eliza-mtp.dts +1 -0
+	vdd-supply = <&vreg_l2b>;

Shouldn't this be l7k? Looking at kera-usb.dtsi I see the vdd-supply for eusb2_phy0 as l7k. I don't see this being overriden by anything else downstream either.

Just bringing it up since I copied this part for another Eliza platform (USB 2 only) and USB failed until I fixed this supply.

Quoted 10 lines
arch/arm64/boot/dts/qcom/eliza-mtp.dts +6 -0
+	vdda12-supply = <&vreg_l4b>;
+
+	phys = <&pm7550ba_eusb2_repeater>;
+
+	status = "okay";
+};
Signature · 2 lines
-- 
2.48.1
#1 lore raw
Quoted 28 lines · Alexander Koskovich
Quoted 18 lines · Abel Vesa

The Eliza MTP features a single USB Type-C port. Its USB 2.0 lines are routed through an eUSB2 repeater provided by the PM7750BA PMIC.

Describe the port and repeater, and enable the USB controller and PHYs.

Also specify the ADSP firmware and enable the remoteproc.

Signed-off-by Abel Vesa <[email protected]>
---
 arch/arm64/boot/dts/qcom/eliza-mtp.dts | 83 ++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
arch/arm64/boot/dts/qcom/eliza-mtp.dts +0 -0
index 90f629800cb0..c31f00e36eee 100644
@@ -6,9 +6,12 @@
 /dts-v1/;

...

arch/arm64/boot/dts/qcom/eliza-mtp.dts

Quoted 3 lines

+&usb_hsphy {

arch/arm64/boot/dts/qcom/eliza-mtp.dts +1 -0
+	vdd-supply = <&vreg_l2b>;

Shouldn't this be l7k? Looking at kera-usb.dtsi I see the vdd-supply for eusb2_phy0 as l7k. I don't see this being overriden by anything else downstream either.

Quoted 2 lines

Just bringing it up since I copied this part for another Eliza platform (USB 2 only) and USB failed until I fixed this supply.

Looking at some diagrams, L7K seems to be the right one indeed

Konrad

#2 lore raw
In reply to Alexander Koskovich
Quoted 28 lines · Alexander Koskovich
Quoted 18 lines · Abel Vesa

The Eliza MTP features a single USB Type-C port. Its USB 2.0 lines are routed through an eUSB2 repeater provided by the PM7750BA PMIC.

Describe the port and repeater, and enable the USB controller and PHYs.

Also specify the ADSP firmware and enable the remoteproc.

Signed-off-by Abel Vesa <[email protected]>
---
 arch/arm64/boot/dts/qcom/eliza-mtp.dts | 83 ++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
arch/arm64/boot/dts/qcom/eliza-mtp.dts +0 -0
index 90f629800cb0..c31f00e36eee 100644
@@ -6,9 +6,12 @@
 /dts-v1/;

...

arch/arm64/boot/dts/qcom/eliza-mtp.dts

Quoted 3 lines

+&usb_hsphy {

arch/arm64/boot/dts/qcom/eliza-mtp.dts +1 -0
+	vdd-supply = <&vreg_l2b>;

Shouldn't this be l7k? Looking at kera-usb.dtsi I see the vdd-supply for eusb2_phy0 as l7k. I don't see this being overriden by anything else downstream either.

Quoted 2 lines

Just bringing it up since I copied this part for another Eliza platform (USB 2 only) and USB failed until I fixed this supply.

Yep. That seems to be the case. Thanks for pointing this out.

Will fix when respinning.