Skip to contentSkip to conversation

drivers/ide/ppc/mpc8xx.c - volatile fix

PATCH New Magnus Damm 1 participant 1 message Dec 11, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/ide/ppc/mpc8xx.c - volatile fix

Hello,

I fixed this in a local tree for a customer half a year ago (mvl-3.1) and forgot to report it to the lists. Now I came across it in vanilla 2.5.10-rc3. I have not tested the fix but it is pretty obvious that access with a non-volatile pointer to hardware is bad, at least with gcc-3 or above.

Please apply. Or ignore if already fixed. =)

Thanks.

/ magnus (needs CC)

drivers/ide/ppc/mpc8xx.c +1 -1
@@ -172,7 +172,7 @@
 	volatile pcmcia_win_t *win;
 	volatile pcmconf8xx_t *pcmp;
 
-	uint *pgcrx;
+	volatile uint *pgcrx;
 	u32 pcmcia_phy_base;
 	u32 pcmcia_phy_end;
 	static unsigned long pcmcia_base = 0;