Skip to contentSkip to conversation

af_unix.c, KBUILD_MODNAME and unix

DISCUSSION Magnus Damm 3 participants 5 messages Mar 20, 2005

lore
Share & tools
lore
#0 lore raw

Hello All,

af_unix.c is currenty built with KBUILD_MODNAME=unix. This seems to work rather well today, but if someone actually tries to use KBUILD_MODNAME then they will end up with a preprocessor surprise:
KBUILD_MODNAME -> unix -> 1, because "unix" is defined to 1.

With other words, if someone adds module_param(foo,...) code to af_unix.c and compiles the code as built in then they will have to use "1.foo" to set the variable instead of "unix.foo" as expected.

Solution? #undef unix?

I came across this when trying to autogenerate parameter documentation...

/ magnus

#1 lore raw
Quoted 7 lines · Magnus Damm

Hello All,

af_unix.c is currenty built with KBUILD_MODNAME=unix. This seems to work rather well today, but if someone actually tries to use KBUILD_MODNAME then they will end up with a preprocessor surprise:
KBUILD_MODNAME -> unix -> 1, because "unix" is defined to 1.

Quoted 5 lines

With other words, if someone adds module_param(foo,...) code to af_unix.c and compiles the code as built in then they will have to use "1.foo" to set the variable instead of "unix.foo" as expected.

Solution? #undef unix?

or maybe -Uunix ?

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
#2 lore raw
Quoted 6 lines
Quoted 4 lines

Hello All,

af_unix.c is currenty built with KBUILD_MODNAME=unix. This seems to Solution? #undef unix?

or maybe -Uunix ?

Why is not KBUILD_MODNAME=af_unix ?

Jan Engelhardt

#3 lore raw
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

af_unix.c is currenty built with KBUILD_MODNAME=unix. This seems to Solution? #undef unix?

or maybe -Uunix ?

Why is not KBUILD_MODNAME=af_unix ?

The exact solution does not matter that much to me, and I'm afraid I do not know how changing KBUILD_MODNAME affects the rest of the codebase. So basically - someone else should decide... but who?

/ magnus

#4 lore raw
Quoted 5 lines
Quoted 1 line

Why is not KBUILD_MODNAME=af_unix ?

The exact solution does not matter that much to me, and I'm afraid I do not know how changing KBUILD_MODNAME affects the rest of the codebase. So basically - someone else should decide... but who?

KBUILD_MODNAME is "not used", which means you can use it for anything that like. You can undef it, redefine, thwap it all over and whatnot. It's a generosity from /usr/bin/make generally providing the module with its own name.

Jan Engelhardt