Skip to contentSkip to conversation

perf tests data_validation: Fixup test header

PATCH In review Arnaldo Carvalho de Melo 2 participants 2 messages May 11 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tests data_validation: Fixup test header

We made a mistake by having the SPDX comment in the second line, where 'perf test' shell support expects the test title, fix it.

Now we can specify a substring and have that test selected:

  root@number:~# perf test truncat
   84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).: Ok
  root@number:~# perf test -vv truncat
   84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).:
  --- start ---
  test child forked, pid 62890
  ---- end(0) ----
   84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).: Ok
  root@number:~#
Fixes 24be50a54cb38cb4 ("perf test: Add truncated perf.data robustness test")
Cc Ian Rogers <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/tests/shell/data_validation.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/tests/shell/data_validation.sh +1 -2
index 649f71b6cdb93202..f8fcc4c0448b0c51 100755
@@ -1,7 +1,6 @@
 #!/bin/bash
+# Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).
 # SPDX-License-Identifier: GPL-2.0
-# Test that perf report handles truncated perf.data gracefully
-# (no crash, no segfault — clean error exit).
 #
 # Exercises the bounds checking and minimum-size validation added
 # by the perf-data-validation hardening series.
Signature · 1 line
2.54.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Arnaldo Carvalho de Melo

We made a mistake by having the SPDX comment in the second line, where 'perf test' shell support expects the test title, fix it.

Now we can specify a substring and have that test selected:

  root@number:~# perf test truncat
   84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).: Ok
  root@number:~# perf test -vv truncat
   84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).:
  --- start ---
  test child forked, pid 62890
  ---- end(0) ----
   84: Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).: Ok
  root@number:~#
Quoted 6 lines
Fixes 24be50a54cb38cb4 ("perf test: Add truncated perf.data robustness test")
Cc Ian Rogers <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>

I plan to send a patch to improve how the test name is read from a script. It is either that or continuing to spend time teaching my LLM not to make checkpatch.pl happy and thereby break this. It seems better that we just teach the code to skip lines containing SPDX.

Thanks,
Ian

Quoted 20 lines
---
 tools/perf/tests/shell/data_validation.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/perf/tests/shell/data_validation.sh +1 -3
index 649f71b6cdb93202..f8fcc4c0448b0c51 100755
@@ -1,7 +1,6 @@
 #!/bin/bash
+# Test that perf report handles truncated perf.data gracefully (no crash, no segfault — clean error exit).
 # SPDX-License-Identifier: GPL-2.0
-# Test that perf report handles truncated perf.data gracefully
-# (no crash, no segfault — clean error exit).
 #
 # Exercises the bounds checking and minimum-size validation added
 # by the perf-data-validation hardening series.
--

2.54.0