Sashiko patch review for live-patching?
Joe Lawrence
maintainerHello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.
Integration appears straightforward: we can submit an MR to add our entry to sashiko-k8s.yaml and customize the bot's email behavior in email_policy.toml.
Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md
Personally, I would vote to set reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from the MAINTAINERS::LIVE PATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.
--
Joe
Song Liu
maintainerHi Joe,
Quoted 6 lines · Joe Lawrence
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.
I think it is a great idea. AFAICT, these bots add a lot of values in the code reviews.
Quoted 4 lines
Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.
Quoted 8 lines
Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.mdPersonally, I would vote to set
reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.
Given the relatively low volume of patches to the livepatch mail list, I think we can use reply_all. But if folks prefer reply_to_author instead, we sure can use the cc list.
Thanks,
Song
Quoted 14 lines · Joe Lawrence
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in
adding live-patching to the mailing lists Sashiko tracks.Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.md
Quoted 8 lines
Personally, I would vote to set reply_to_author. I don't have a strong
opinion on the other custom options, provided that the CC list is opt-in
rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch
review.
We can start with reply_to_author for some time before opting for reply_all. At least in my last patches, it was quite good and helpful.
Quoted 4 lines
--
Joe
Josh Poimboeuf
maintainerQuoted 4 lines · Song Liu
Hi Joe,
Quoted 1 line · Joe Lawrence
Quoted 8 lines
Quoted 5 lines
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.I think it is a great idea. AFAICT, these bots add a lot of values in the code reviews.
+1
Quoted 13 lines
Quoted 4 lines
Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.Quoted 8 lines
Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.mdPersonally, I would vote to set
reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.
Quoted 3 lines
Given the relatively low volume of patches to the livepatch mail list, I think we can use
reply_all. But if folks preferreply_to_authorinstead, we sure can use the cc list.
I would vote reply_all. The signal/noise ratio isn't perfect, but it's high enough to be useful in many cases. That way the maintainers/reviewers are aware of any potential issues, and it avoids duplicating review work and fragmenting conversations.
Signature · 1 line
Josh
Miroslav Benes
maintainerQuoted 29 lines · Josh Poimboeuf
Quoted 4 lines · Song Liu
Hi Joe,
Quoted 1 line · Joe Lawrence
Quoted 8 lines
Quoted 5 lines
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.I think it is a great idea. AFAICT, these bots add a lot of values in the code reviews.
+1
Quoted 13 lines
Quoted 12 lines
Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.mdPersonally, I would vote to set
reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.
Quoted 8 lines
Quoted 3 lines
Given the relatively low volume of patches to the livepatch mail list, I think we can use
reply_all. But if folks preferreply_to_authorinstead, we sure can use the cc list.I would vote
reply_all. The signal/noise ratio isn't perfect, but it's high enough to be useful in many cases. That way the maintainers/reviewers are aware of any potential issues, and it avoids duplicating review work and fragmenting conversations.
+1
Miroslav
Petr Mladek
maintainerQuoted 29 lines · Josh Poimboeuf
Quoted 4 lines · Song Liu
Hi Joe,
Quoted 1 line · Joe Lawrence
Quoted 8 lines
Quoted 5 lines
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.I think it is a great idea. AFAICT, these bots add a lot of values in the code reviews.
+1
Quoted 13 lines
Quoted 12 lines
Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.mdPersonally, I would vote to set
reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.
Quoted 8 lines
Quoted 3 lines
Given the relatively low volume of patches to the livepatch mail list, I think we can use
reply_all. But if folks preferreply_to_authorinstead, we sure can use the cc list.I would vote
reply_all. The signal/noise ratio isn't perfect, but it's high enough to be useful in many cases. That way the maintainers/reviewers are aware of any potential issues, and it avoids duplicating review work and fragmenting conversations.
I agree. And it might even motivate us to update the subsystem specific review prompts so that the review gets improved over time.
Best Regards,
Petr
Song Liu
maintainerQuoted 35 lines · Petr Mladek
Quoted 33 lines · Josh Poimboeuf
Quoted 4 lines · Song Liu
Hi Joe,
Quoted 1 line · Joe Lawrence
Quoted 8 lines
Quoted 5 lines
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.I think it is a great idea. AFAICT, these bots add a lot of values in the code reviews.
+1
Quoted 16 lines
Quoted 4 lines
Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.Quoted 8 lines
Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.mdPersonally, I would vote to set
reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.Given the relatively low volume of patches to the livepatch mail list, I think we can use
reply_all. But if folks preferreply_to_authorinstead, we sure can use the cc list.
Quoted 7 lines
Quoted 4 lines
I would vote
reply_all. The signal/noise ratio isn't perfect, but it's high enough to be useful in many cases. That way the maintainers/reviewers are aware of any potential issues, and it avoids duplicating review work and fragmenting conversations.I agree. And it might even motivate us to update the subsystem specific review prompts so that the review gets improved over time.
+1 for livepatch specific prompts. We sure have some unique constraints due to the nature of livepatch.
Thanks,
Song
Joe Lawrence
maintainerQuoted 10 lines · Joe Lawrence
Hello live-patching maintainers,
I've noticed several references to the Sashiko (https://sashiko.dev/)
kernel review bot on this list and was wondering if there is interest in adding live-patching to the mailing lists Sashiko tracks.Integration appears straightforward: we can submit an MR to add our entry to
sashiko-k8s.yamland customize the bot's email behavior in email_policy.toml.
Quoted 9 lines
Full Sashiko Maintainer documentation is available here:
https://github.com/sashiko-dev/sashiko/blob/main/MAINTAINERS_GUIDE.mdPersonally, I would vote to set
reply_to_author. I don't have a strong opinion on the other custom options, provided that the CC list is opt-in rather than simply mirrored from theMAINTAINERS::LIVEPATCHING file. Either way, I've found the Sashiko web interface very helpful in patch review.
Sashiko.dev MR for [email protected] w/reply-all policy:
https://github.com/sashiko-dev/sashiko/pull/195
Signature · 1 line
Joe