Skip to contentSkip to conversation

sh: ecovec24: use static device properties to describe the touchscreen

PATCH RESEND In review Dmitry Torokhov 4 participants 6 messages Jul 13 – Sep 16

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 sh: ecovec24: use static device properties to describe the touchscreen

Convert the board to use static device properties instead of platform data to describe the touchscreen, so that support for platform data can be removed from tsc2007 driver (ecovec24 is the last board using this mechanism of describing tsc2007).

Device properties do not allow custom board methods, so the method for getting "pen down" state was removed (the driver is capable of working without it). If this functionality is needed proper pin control/gpio support needs to be implemented so that the same pin can serve as an input GPIO and an interrupt.

---

This is a resend of the patch I sent in August of 2024. My fault of not noticing reply from Adrian inquiring about potential negative impact from not having GPIO-based "pen down" detection. I believe this is fine, the "pen down" is an optional feature and the driver can detect the touches even when it is not specified. Additionally, this is an evaluation board, so user impact should be negligible.

However the bigger question is whether ecovec24 board still relevant. According to my research it has the following regressions currently unfixed:

5716fb9bd9c6 ("mmc: spi: Convert to use GPIO descriptors")
- MMC SPI device naming broken (broke SD fallback mode)

9fda6693335c ("spi: sh-msiof: Convert to use GPIO descriptors")
- SPI CS polarity inverted (broke initialization on the MSIOF0 SPI bus)

c2f9b05fd5c1 ("media: arch: sh: ecovec: Use new renesas-ceu camera driver")
- Camera array sentinel missing (causes out-of-bounds reads and potentially kernel panics)
- Camera standby polarity inverted (enadvertently keeps cameras permanently powered off)
- Camera disabled iby default (board defconfig points to a deleted driver)

They are ~6 years old, so I wonder: do people actually *actively* use this board with modern kernels? Should it simply be removed?

Thanks!

 arch/sh/boards/mach-ecovec24/setup.c | 38 ++++++++--------------------
 1 file changed, 11 insertions(+), 27 deletions(-)
arch/sh/boards/mach-ecovec24/setup.c +11 -27
index a641e26f8fdf..110a77f903b5 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_data/tmio.h>
 #include <linux/platform_data/tsc2007.h>
 #include <linux/platform_device.h>
+#include <linux/property.h>
 #include <linux/regulator/fixed.h>
 #include <linux/regulator/machine.h>
 #include <linux/sh_eth.h>
@@ -589,39 +590,21 @@ static struct platform_device keysc_device = {
 /* TouchScreen */
 #define IRQ0 evt2irq(0x600)
 
-static int ts_get_pendown_state(struct device *dev)
-{
-	int val = 0;
-	gpio_free(GPIO_FN_INTC_IRQ0);
-	gpio_request(GPIO_PTZ0, NULL);
-	gpio_direction_input(GPIO_PTZ0);
-
-	val = gpio_get_value(GPIO_PTZ0);
-
-	gpio_free(GPIO_PTZ0);
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-
-	return val ? 0 : 1;
-}
-
-static int ts_init(void)
-{
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-	return 0;
-}
+static const struct property_entry tsc2007_properties[] = {
+	PROPERTY_ENTRY_U32("ti,x-plate-ohms", 180),
+	{ }
+};
 
-static struct tsc2007_platform_data tsc2007_info = {
-	.model			= 2007,
-	.x_plate_ohms		= 180,
-	.get_pendown_state	= ts_get_pendown_state,
-	.init_platform_hw	= ts_init,
+static const struct software_node tsc2007_swnode = {
+	.name = "tsc2007",
+	.properties = tsc2007_properties,
 };
 
 static struct i2c_board_info ts_i2c_clients = {
 	I2C_BOARD_INFO("tsc2007", 0x48),
 	.type		= "tsc2007",
-	.platform_data	= &tsc2007_info,
 	.irq		= IRQ0,
+	.swnode		= &tsc2007_swnode,
 };
 
 static struct regulator_consumer_supply cn12_power_consumers[] =
@@ -1242,8 +1225,9 @@ static int __init arch_setup(void)
 		gpio_direction_output(GPIO_PTF4, 1);
 
 		/* enable TouchScreen */
-		i2c_register_board_info(0, &ts_i2c_clients, 1);
+		gpio_request(GPIO_FN_INTC_IRQ0, NULL);
 		irq_set_irq_type(IRQ0, IRQ_TYPE_LEVEL_LOW);
+		i2c_register_board_info(0, &ts_i2c_clients, 1);
 	}
 
 	/* enable CEU0 */
Signature · 5 lines
2.55.0.795.g602f6c329a-goog


-- 
Dmitry
#1 lore raw
Quoted 39 lines · Dmitry Torokhov

Convert the board to use static device properties instead of platform data to describe the touchscreen, so that support for platform data can be removed from tsc2007 driver (ecovec24 is the last board using this mechanism of describing tsc2007).

Device properties do not allow custom board methods, so the method for getting "pen down" state was removed (the driver is capable of working without it). If this functionality is needed proper pin control/gpio support needs to be implemented so that the same pin can serve as an input GPIO and an interrupt.

---

This is a resend of the patch I sent in August of 2024. My fault of not noticing reply from Adrian inquiring about potential negative impact from not having GPIO-based "pen down" detection. I believe this is fine, the "pen down" is an optional feature and the driver can detect the touches even when it is not specified. Additionally, this is an evaluation board, so user impact should be negligible.

However the bigger question is whether ecovec24 board still relevant. According to my research it has the following regressions currently unfixed:

5716fb9bd9c6 ("mmc: spi: Convert to use GPIO descriptors")
- MMC SPI device naming broken (broke SD fallback mode)

9fda6693335c ("spi: sh-msiof: Convert to use GPIO descriptors")
- SPI CS polarity inverted (broke initialization on the MSIOF0 SPI bus)

c2f9b05fd5c1 ("media: arch: sh: ecovec: Use new renesas-ceu camera driver")
- Camera array sentinel missing (causes out-of-bounds reads and potentially kernel panics)
- Camera standby polarity inverted (enadvertently keeps cameras permanently powered off)
- Camera disabled iby default (board defconfig points to a deleted driver)

Quoted 2 lines

They are ~6 years old, so I wonder: do people actually *actively* use this board with modern kernels? Should it simply be removed?

John, gentle ping...

Quoted 81 lines

Thanks!

 arch/sh/boards/mach-ecovec24/setup.c | 38 ++++++++--------------------
 1 file changed, 11 insertions(+), 27 deletions(-)
arch/sh/boards/mach-ecovec24/setup.c +11 -27
index a641e26f8fdf..110a77f903b5 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_data/tmio.h>
 #include <linux/platform_data/tsc2007.h>
 #include <linux/platform_device.h>
+#include <linux/property.h>
 #include <linux/regulator/fixed.h>
 #include <linux/regulator/machine.h>
 #include <linux/sh_eth.h>
@@ -589,39 +590,21 @@ static struct platform_device keysc_device = {
 /* TouchScreen */
 #define IRQ0 evt2irq(0x600)
 
-static int ts_get_pendown_state(struct device *dev)
-{
-	int val = 0;
-	gpio_free(GPIO_FN_INTC_IRQ0);
-	gpio_request(GPIO_PTZ0, NULL);
-	gpio_direction_input(GPIO_PTZ0);
-
-	val = gpio_get_value(GPIO_PTZ0);
-
-	gpio_free(GPIO_PTZ0);
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-
-	return val ? 0 : 1;
-}
-
-static int ts_init(void)
-{
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-	return 0;
-}
+static const struct property_entry tsc2007_properties[] = {
+	PROPERTY_ENTRY_U32("ti,x-plate-ohms", 180),
+	{ }
+};
 
-static struct tsc2007_platform_data tsc2007_info = {
-	.model			= 2007,
-	.x_plate_ohms		= 180,
-	.get_pendown_state	= ts_get_pendown_state,
-	.init_platform_hw	= ts_init,
+static const struct software_node tsc2007_swnode = {
+	.name = "tsc2007",
+	.properties = tsc2007_properties,
 };
 
 static struct i2c_board_info ts_i2c_clients = {
 	I2C_BOARD_INFO("tsc2007", 0x48),
 	.type		= "tsc2007",
-	.platform_data	= &tsc2007_info,
 	.irq		= IRQ0,
+	.swnode		= &tsc2007_swnode,
 };
 
 static struct regulator_consumer_supply cn12_power_consumers[] =
@@ -1242,8 +1225,9 @@ static int __init arch_setup(void)
 		gpio_direction_output(GPIO_PTF4, 1);
 
 		/* enable TouchScreen */
-		i2c_register_board_info(0, &ts_i2c_clients, 1);
+		gpio_request(GPIO_FN_INTC_IRQ0, NULL);
 		irq_set_irq_type(IRQ0, IRQ_TYPE_LEVEL_LOW);
+		i2c_register_board_info(0, &ts_i2c_clients, 1);
 	}
 
 	/* enable CEU0 */
Signature · 1 line
2.55.0.795.g602f6c329a-goog
Signature · 1 line
Dmitry
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Dmitry Torokhov
Quoted 5 lines · Dmitry Torokhov

Convert the board to use static device properties instead of platform data to describe the touchscreen, so that support for platform data can be removed from tsc2007 driver (ecovec24 is the last board using this mechanism of describing tsc2007).

Quoted 9 lines

Device properties do not allow custom board methods, so the method for getting "pen down" state was removed (the driver is capable of working without it). If this functionality is needed proper pin control/gpio support needs to be implemented so that the same pin can serve as an input GPIO and an interrupt.

---

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Dmitry Torokhov
Quoted 5 lines · Dmitry Torokhov

Convert the board to use static device properties instead of platform data to describe the touchscreen, so that support for platform data can be removed from tsc2007 driver (ecovec24 is the last board using this mechanism of describing tsc2007).

Quoted 7 lines

Device properties do not allow custom board methods, so the method for getting "pen down" state was removed (the driver is capable of working without it). If this functionality is needed proper pin control/gpio support needs to be implemented so that the same pin can serve as an input GPIO and an interrupt.

Yours,
Linus Walleij

#4 lore raw

Hi Linus and Dmitry,

Quoted 14 lines · Linus Walleij
Quoted 11 lines · Dmitry Torokhov

Convert the board to use static device properties instead of platform data to describe the touchscreen, so that support for platform data can be removed from tsc2007 driver (ecovec24 is the last board using this mechanism of describing tsc2007).

Device properties do not allow custom board methods, so the method for getting "pen down" state was removed (the driver is capable of working without it). If this functionality is needed proper pin control/gpio support needs to be implemented so that the same pin can serve as an input GPIO and an interrupt.

Quoted 3 lines
Quoted 1 line

Thanks a lot for the review! I'm working on them now.

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
maintainer Reviewed-by on v1 1/1
#5 lore raw
In reply to Dmitry Torokhov

Hi Dmitry,

Quoted 39 lines · Dmitry Torokhov

Convert the board to use static device properties instead of platform data to describe the touchscreen, so that support for platform data can be removed from tsc2007 driver (ecovec24 is the last board using this mechanism of describing tsc2007).

Device properties do not allow custom board methods, so the method for getting "pen down" state was removed (the driver is capable of working without it). If this functionality is needed proper pin control/gpio support needs to be implemented so that the same pin can serve as an input GPIO and an interrupt.

---

This is a resend of the patch I sent in August of 2024. My fault of not noticing reply from Adrian inquiring about potential negative impact from not having GPIO-based "pen down" detection. I believe this is fine, the "pen down" is an optional feature and the driver can detect the touches even when it is not specified. Additionally, this is an evaluation board, so user impact should be negligible.

However the bigger question is whether ecovec24 board still relevant. According to my research it has the following regressions currently unfixed:

5716fb9bd9c6 ("mmc: spi: Convert to use GPIO descriptors")
- MMC SPI device naming broken (broke SD fallback mode)

9fda6693335c ("spi: sh-msiof: Convert to use GPIO descriptors")
- SPI CS polarity inverted (broke initialization on the MSIOF0 SPI bus)

c2f9b05fd5c1 ("media: arch: sh: ecovec: Use new renesas-ceu camera driver")
- Camera array sentinel missing (causes out-of-bounds reads and potentially kernel panics)
- Camera standby polarity inverted (enadvertently keeps cameras permanently powered off)
- Camera disabled iby default (board defconfig points to a deleted driver)

Quoted 2 lines

They are ~6 years old, so I wonder: do people actually *actively* use this board with modern kernels? Should it simply be removed?

We want to switch arch/sh to using device trees in the future anyway, then we can decide which boards to keep and which ones to remove. We have a patch series by Yoshinori Sato to convert arch/sh to device trees. It still needs some work though.

Quoted 79 lines

Thanks!

 arch/sh/boards/mach-ecovec24/setup.c | 38 ++++++++--------------------
 1 file changed, 11 insertions(+), 27 deletions(-)
arch/sh/boards/mach-ecovec24/setup.c +11 -27
index a641e26f8fdf..110a77f903b5 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_data/tmio.h>
 #include <linux/platform_data/tsc2007.h>
 #include <linux/platform_device.h>
+#include <linux/property.h>
 #include <linux/regulator/fixed.h>
 #include <linux/regulator/machine.h>
 #include <linux/sh_eth.h>
@@ -589,39 +590,21 @@ static struct platform_device keysc_device = {
 /* TouchScreen */
 #define IRQ0 evt2irq(0x600)
 
-static int ts_get_pendown_state(struct device *dev)
-{
-	int val = 0;
-	gpio_free(GPIO_FN_INTC_IRQ0);
-	gpio_request(GPIO_PTZ0, NULL);
-	gpio_direction_input(GPIO_PTZ0);
-
-	val = gpio_get_value(GPIO_PTZ0);
-
-	gpio_free(GPIO_PTZ0);
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-
-	return val ? 0 : 1;
-}
-
-static int ts_init(void)
-{
-	gpio_request(GPIO_FN_INTC_IRQ0, NULL);
-	return 0;
-}
+static const struct property_entry tsc2007_properties[] = {
+	PROPERTY_ENTRY_U32("ti,x-plate-ohms", 180),
+	{ }
+};
 
-static struct tsc2007_platform_data tsc2007_info = {
-	.model			= 2007,
-	.x_plate_ohms		= 180,
-	.get_pendown_state	= ts_get_pendown_state,
-	.init_platform_hw	= ts_init,
+static const struct software_node tsc2007_swnode = {
+	.name = "tsc2007",
+	.properties = tsc2007_properties,
 };
 
 static struct i2c_board_info ts_i2c_clients = {
 	I2C_BOARD_INFO("tsc2007", 0x48),
 	.type		= "tsc2007",
-	.platform_data	= &tsc2007_info,
 	.irq		= IRQ0,
+	.swnode		= &tsc2007_swnode,
 };
 
 static struct regulator_consumer_supply cn12_power_consumers[] =
@@ -1242,8 +1225,9 @@ static int __init arch_setup(void)
 		gpio_direction_output(GPIO_PTF4, 1);
 
 		/* enable TouchScreen */
-		i2c_register_board_info(0, &ts_i2c_clients, 1);
+		gpio_request(GPIO_FN_INTC_IRQ0, NULL);
 		irq_set_irq_type(IRQ0, IRQ_TYPE_LEVEL_LOW);
+		i2c_register_board_info(0, &ts_i2c_clients, 1);
 	}
 
 	/* enable CEU0 */
Signature · 1 line
2.55.0.795.g602f6c329a-goog

Looks good to me. I'll pick this up for v7.4.

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913