Skip to contentSkip to conversation

gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

PATCH Applied Dmitry Torokhov 4 participants 6 messages Jul 13 – Jul 15 GPIO

lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry followed by an empty sentinel entry. The sentinel entry has a trailing comma which is unnecessary. Remove it.

Assisted-by Antigravity:gemini-3.5-flash
Signed-off-by Dmitry Torokhov <[email protected]>
---
 include/linux/gpio/machine.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/gpio/machine.h +1 -1
index 5eb88f5d0630..1a141056716f 100644
@@ -54,7 +54,7 @@ static struct gpiod_lookup_table _name = {				\
 	.dev_id = _dev_id,						\
 	.table = {							\
 		GPIO_LOOKUP(_key, _chip_hwnum, _con_id, _flags),	\
-		{},							\
+		{ }							\
 	},								\
 }
Signature · 5 lines
2.55.0.795.g602f6c329a-goog


-- 
Dmitry
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Dmitry Torokhov

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry

GPIO_LOOKUP_SINGLE()

Quoted 2 lines

followed by an empty sentinel entry. The sentinel entry has a trailing comma which is unnecessary. Remove it.

Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 1 line · Dmitry Torokhov

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry

GPIO_LOOKUP_SINGLE()

I fixed it when applying.

Quoted 5 lines
Quoted 2 lines

followed by an empty sentinel entry. The sentinel entry has a trailing comma which is unnecessary. Remove it.

Reviewed-by Andy Shevchenko <[email protected]>

I queued it but I do consider it a bit of a needless churn TBH.

Bart

#3 lore raw
Quoted 8 lines · Bartosz Golaszewski
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Dmitry Torokhov

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry

GPIO_LOOKUP_SINGLE()

I fixed it when applying.

Thanks!

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

followed by an empty sentinel entry. The sentinel entry has a trailing comma which is unnecessary. Remove it.

Reviewed-by Andy Shevchenko <[email protected]>

I queued it but I do consider it a bit of a needless churn TBH.

You should really be against Uwe's patches then! :-)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#4 lore raw
Quoted 12 lines · Andy Shevchenko
Quoted 8 lines · Bartosz Golaszewski
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Dmitry Torokhov

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry

GPIO_LOOKUP_SINGLE()

I fixed it when applying.

Thanks!

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

followed by an empty sentinel entry. The sentinel entry has a trailing comma which is unnecessary. Remove it.

Reviewed-by Andy Shevchenko <[email protected]>

I queued it but I do consider it a bit of a needless churn TBH.

You should really be against Uwe's patches then! :-)

He's fixing more stuff and removing trailing commas is just part of it. And as you can see - I did apply it and will apply Uwe's series too.

Bart

Applied
#5 lore raw
In reply to Dmitry Torokhov
Quoted 5 lines · Dmitry Torokhov

The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry followed by an empty sentinel entry. The sentinel entry has a trailing comma which is unnecessary. Remove it.

Applied, thanks!

[1/1] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE

      https://git.kernel.org/brgl/c/7cefedf0c4a2d943f96f440b433bf71a1a8261d7

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>