Skip to contentSkip to conversation

Quirk for reboot stalls on a Dell Optiplex 330

PATCH Applied Steve Conklin 2 participants 2 messages Nov 14, 2008 – Nov 18, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Quirk for reboot stalls on a Dell Optiplex 330

Quoted 1 line

From 6269c416487b41576107ef6f535639d3177daa43 Mon Sep 17 00:00:00 2001

From: Leann Ogasawara <[email protected]>
Date: Wed, 12 Nov 2008 17:01:54 -0600
Subject: [PATCH] Quirk for reboot stalls on a Dell Optiplex 330

Dell Optiplex 330 appears to hang on reboot. This is resolved by adding a quirk to set bios reboot.

---
 arch/x86/kernel/reboot.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
arch/x86/kernel/reboot.c +9 -0
index 904a8ea..0d897f8 100644
@@ -169,6 +169,15 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "0KW626"),
 		},
 	},
+	{   /* Handle problems with rebooting on Dell Optiplex 330 with 0KP561 */
+		.callback = set_bios_reboot,
+		.ident = "Dell OptiPlex 330",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 330"),
+			DMI_MATCH(DMI_BOARD_NAME, "0KP561"),
+		},
+	},
 	{	/* Handle problems with rebooting on Dell 2400's */
 		.callback = set_bios_reboot,
 		.ident = "Dell PowerEdge 2400",
Signature · 1 line
1.5.6.3
Applied
#1 lore raw
Quoted 5 lines · Steve Conklin
Quoted 1 line

From 6269c416487b41576107ef6f535639d3177daa43 Mon Sep 17 00:00:00 2001

From: Leann Ogasawara <[email protected]>
Date: Wed, 12 Nov 2008 17:01:54 -0600
Subject: [PATCH] Quirk for reboot stalls on a Dell Optiplex 330

Quoted 8 lines

Dell Optiplex 330 appears to hang on reboot. This is resolved by adding a quirk to set bios reboot.

---
 arch/x86/kernel/reboot.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

applied to tip/x86/quirks, thanks Steve!

arch/x86/kernel/reboot.c static struct dmi_system_id __initdata reboot_dmi_table[] = { · line 178

Quoted 7 lines
arch/x86/kernel/reboot.c +7 -0
+	{   /* Handle problems with rebooting on Dell Optiplex 330 with 0KP561 */
+		.callback = set_bios_reboot,
+		.ident = "Dell OptiPlex 330",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 330"),
+			DMI_MATCH(DMI_BOARD_NAME, "0KP561"),

is the board filter really necessary? It might unnecessarily filter out small variations in board names.

Ingo