Skip to contentSkip to conversation

latest scan for "bad" config variable references in kernel tree

DISCUSSION Robert P. J. Day 1 participant 1 message Jul 23, 2010

lore
Share & tools
lore
#0 lore raw

as of 2.6.35-rc6, i ran another scan of the tree, looking for "bad"
config variable references, as in, preprocessor tests of CONFIG_ variables that aren't defined in any Kconfig file that i can see.

it's all broken down by directory and subdirectory:

http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables

as an example, here's what showed up under drivers/mmc:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

MMC_EMBEDDED_SDIO

drivers/mmc/host/msm_sdcc.c:1148:#ifdef CONFIG_MMC_EMBEDDED_SDIO

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

MMC_MSM7X00A_RESUME_IN_WQ

drivers/mmc/host/msm_sdcc.h:238:#ifdef CONFIG_MMC_MSM7X00A_RESUME_IN_WQ drivers/mmc/host/msm_sdcc.c:1060:#ifdef CONFIG_MMC_MSM7X00A_RESUME_IN_WQ

as in, there's a test for "CONFIG_MMC_EMBEDDED_SDIO" when there is
no definition of such a variable in a Kconfig file.

more scanning coming later, but that page covers the whole tree
looking for just that property.

rday

Signature · 9 lines
========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Top-notch, inexpensive online Linux/OSS/kernel courses
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================