Skip to contentSkip to conversation

sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0 (fwd)

PATCH In review Julia Lawall 2 participants 2 messages Jun 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 36/37 sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0 (fwd)

Please check on line 285.

julia

---------- Forwarded message ----------
Date: Fri, 16 Jun 2017 04:21:36 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: [asoc:topic/rcar 36/37] sound/soc/sh/rcar/ssi.c:285:5-14: WARNING:
Unsigned expression compared with zero: main_rate < 0

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rcar
head:   8cc03722403a5153054993388857e4e565dcdfb1
commit: ef4cf5d6a143e04e149ad81fc491fe10855544fe [36/37] ASoC: rsnd: add rsnd_ssi_clk_query()

:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Quoted 1 line
Quoted 1 line

sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0

git remote add asoc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
git remote update asoc
git checkout ef4cf5d6a143e04e149ad81fc491fe10855544fe
vim +285 sound/soc/sh/rcar/ssi.c

e7d850dd1 Kuninori Morimoto 2015-10-26  269  	if (ssi_parent_mod && !rsnd_ssi_is_parent(mod, io))
e7d850dd1 Kuninori Morimoto 2015-10-26  270  		return 0;
e7d850dd1 Kuninori Morimoto 2015-10-26  271
b4c83b171 Kuninori Morimoto 2015-12-17  272  	if (rsnd_ssi_is_multi_slave(mod, io))
b4c83b171 Kuninori Morimoto 2015-12-17  273  		return 0;
b4c83b171 Kuninori Morimoto 2015-12-17  274
e7d850dd1 Kuninori Morimoto 2015-10-26  275  	if (ssi->usrcnt > 1) {
e7d850dd1 Kuninori Morimoto 2015-10-26  276  		if (ssi->rate != rate) {
e7d850dd1 Kuninori Morimoto 2015-10-26  277  			dev_err(dev, "SSI parent/child should use same rate\n");
e7d850dd1 Kuninori Morimoto 2015-10-26  278  			return -EINVAL;
e7d850dd1 Kuninori Morimoto 2015-10-26  279  		}
e7d850dd1 Kuninori Morimoto 2015-10-26  280
e7d850dd1 Kuninori Morimoto 2015-10-26  281  		return 0;
e7d850dd1 Kuninori Morimoto 2015-10-26  282  	}
e7d850dd1 Kuninori Morimoto 2015-10-26  283
ef4cf5d6a Kuninori Morimoto 2017-06-15  284  	main_rate = rsnd_ssi_clk_query(priv, rate, chan, &idx);
ef4cf5d6a Kuninori Morimoto 2017-06-15 @285  	if (main_rate < 0) {
ef4cf5d6a Kuninori Morimoto 2017-06-15  286  		dev_err(dev, "unsupported clock rate\n");
ef4cf5d6a Kuninori Morimoto 2017-06-15  287  		return -EIO;
ef4cf5d6a Kuninori Morimoto 2017-06-15  288  	}
ae5c32230 Kuninori Morimoto 2013-07-21  289
b76e218ae Kuninori Morimoto 2015-09-10  290  	ret = rsnd_adg_ssi_clk_try_start(mod, main_rate);
ef4cf5d6a Kuninori Morimoto 2017-06-15  291  	if (ret < 0)
ef4cf5d6a Kuninori Morimoto 2017-06-15  292  		return ret;
ae5c32230 Kuninori Morimoto 2013-07-21  293

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#1 lore raw

Hi Julia

Quoted 7 lines
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rcar
head:   8cc03722403a5153054993388857e4e565dcdfb1
commit: ef4cf5d6a143e04e149ad81fc491fe10855544fe [36/37] ASoC: rsnd: add rsnd_ssi_clk_query()

:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Quoted 1 line
Quoted 1 line

sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression compared with zero: main_rate < 0

Thanks
I didn't notice about it.
Will post fixup patch soon

Best regards
---
Kuninori Morimoto