Skip to contentSkip to conversation

sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data (fwd)

PATCH In review Julia Lawall 2 participants 2 messages Jul 1, 2017 – Jul 3, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 37/40 sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data (fwd)

This doesn't show enough of the context to see the allocation, but please check.

thanks,
julia

---------- Forwarded message ----------
Date: Sat, 1 Jul 2017 02:40:21 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: [asoc:topic/intel 37/40] sound/soc/intel/skylake/skl-debug.c:53:1-6:
WARNING: invalid free of devm_ allocated data

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel
head:   bdd0384a5ada8bb5745e5f29c10a5ba88827efad
commit: 5cdf6c09ca9de3f037ba2d770206f3374459602d [37/40] ASoC: Intel: Skylake: Add debugfs support

:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago

Quoted 1 line
Quoted 1 line

sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data

git remote add asoc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
git remote update asoc
git checkout 5cdf6c09ca9de3f037ba2d770206f3374459602d
vim +53 sound/soc/intel/skylake/skl-debug.c

5cdf6c09 Vinod Koul 2017-06-30  37  				   skl->platform->component.debugfs_root);
5cdf6c09 Vinod Koul 2017-06-30  38  	if (IS_ERR(d->fs) || !d->fs) {
5cdf6c09 Vinod Koul 2017-06-30  39  		dev_err(&skl->pci->dev, "debugfs root creation failed\n");
5cdf6c09 Vinod Koul 2017-06-30  40  		return NULL;
5cdf6c09 Vinod Koul 2017-06-30  41  	}
5cdf6c09 Vinod Koul 2017-06-30  42
5cdf6c09 Vinod Koul 2017-06-30  43  	d->skl = skl;
5cdf6c09 Vinod Koul 2017-06-30  44  	d->dev = &skl->pci->dev;
5cdf6c09 Vinod Koul 2017-06-30  45
5cdf6c09 Vinod Koul 2017-06-30  46  	return d;
5cdf6c09 Vinod Koul 2017-06-30  47  }
5cdf6c09 Vinod Koul 2017-06-30  48
5cdf6c09 Vinod Koul 2017-06-30  49  void skl_debugfs_exit(struct skl_debug *d)
5cdf6c09 Vinod Koul 2017-06-30  50  {
5cdf6c09 Vinod Koul 2017-06-30  51  	debugfs_remove_recursive(d->fs);
5cdf6c09 Vinod Koul 2017-06-30  52

5cdf6c09 Vinod Koul 2017-06-30 @53 kfree(d);
5cdf6c09 Vinod Koul 2017-06-30 54
5cdf6c09 Vinod Koul 2017-06-30 55 }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

#1 lore raw
Quoted 2 lines · Julia Lawall

This doesn't show enough of the context to see the allocation, but please check.

Yeah this looks right to me, will send a patch to remove the kfree.

Thanks for reporting

Quoted 48 lines

thanks,
julia

---------- Forwarded message ----------
Date: Sat, 1 Jul 2017 02:40:21 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: [asoc:topic/intel 37/40] sound/soc/intel/skylake/skl-debug.c:53:1-6:
WARNING: invalid free of devm_ allocated data

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel
head:   bdd0384a5ada8bb5745e5f29c10a5ba88827efad
commit: 5cdf6c09ca9de3f037ba2d770206f3374459602d [37/40] ASoC: Intel: Skylake: Add debugfs support

:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago

Quoted 1 line
Quoted 1 line

sound/soc/intel/skylake/skl-debug.c:53:1-6: WARNING: invalid free of devm_ allocated data

git remote add asoc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
git remote update asoc
git checkout 5cdf6c09ca9de3f037ba2d770206f3374459602d
vim +53 sound/soc/intel/skylake/skl-debug.c

5cdf6c09 Vinod Koul 2017-06-30  37  				   skl->platform->component.debugfs_root);
5cdf6c09 Vinod Koul 2017-06-30  38  	if (IS_ERR(d->fs) || !d->fs) {
5cdf6c09 Vinod Koul 2017-06-30  39  		dev_err(&skl->pci->dev, "debugfs root creation failed\n");
5cdf6c09 Vinod Koul 2017-06-30  40  		return NULL;
5cdf6c09 Vinod Koul 2017-06-30  41  	}
5cdf6c09 Vinod Koul 2017-06-30  42
5cdf6c09 Vinod Koul 2017-06-30  43  	d->skl = skl;
5cdf6c09 Vinod Koul 2017-06-30  44  	d->dev = &skl->pci->dev;
5cdf6c09 Vinod Koul 2017-06-30  45
5cdf6c09 Vinod Koul 2017-06-30  46  	return d;
5cdf6c09 Vinod Koul 2017-06-30  47  }
5cdf6c09 Vinod Koul 2017-06-30  48
5cdf6c09 Vinod Koul 2017-06-30  49  void skl_debugfs_exit(struct skl_debug *d)
5cdf6c09 Vinod Koul 2017-06-30  50  {
5cdf6c09 Vinod Koul 2017-06-30  51  	debugfs_remove_recursive(d->fs);
5cdf6c09 Vinod Koul 2017-06-30  52

5cdf6c09 Vinod Koul 2017-06-30 @53 kfree(d);
5cdf6c09 Vinod Koul 2017-06-30 54
5cdf6c09 Vinod Koul 2017-06-30 55 }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Signature · 1 line
~Vinod