Skip to contentSkip to conversation

columns

DISCUSSION Julia Lawall 2 participants 4 messages Jan 6, 2018 – Jan 8, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hello,

I have been working with Frank Rowand on a v7 of file and line number annotations in the -O dts output of the device tree compiler.

I wanted to make an --annotate-full option that would print the full filename, and starting and ending line and column numbers.

The following commit:

commit 728c5e87c655c17c2fbc1d5386b12ff328e0fc76

Author: David Gibson <[email protected]>
Date:   Tue Dec 8 14:24:42 2009 +1100

extends the position mechanism with columns, but considers a tab to be 8 column. Would it be ok to drop this feature? I have the impression that counting 1 column for a tab would be more useful for actually finding the referenced code.

thanks,
julia

#1 lore raw
Quoted 10 lines · Julia Lawall

Hello,

I have been working with Frank Rowand on a v7 of file and line number annotations in the -O dts output of the device tree compiler.

I wanted to make an --annotate-full option that would print the full filename, and starting and ending line and column numbers.

The following commit:

Quoted 8 lines

commit 728c5e87c655c17c2fbc1d5386b12ff328e0fc76

Author: David Gibson <[email protected]>
Date:   Tue Dec 8 14:24:42 2009 +1100

extends the position mechanism with columns, but considers a tab to be 8 column. Would it be ok to drop this feature? I have the impression that counting 1 column for a tab would be more useful for actually finding the referenced code.

Hrm. I set it up that way initially so that the reported columns would match what shows up inside an editor (e.g. emacs 'column-number-mode').

So, I think I'll need to see a more developed case for why not expanding tabs this way is preferable before making the change.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 20 lines · David Gibson
Quoted 10 lines · Julia Lawall

Hello,

I have been working with Frank Rowand on a v7 of file and line number annotations in the -O dts output of the device tree compiler.

I wanted to make an --annotate-full option that would print the full filename, and starting and ending line and column numbers.

The following commit:

Quoted 8 lines

commit 728c5e87c655c17c2fbc1d5386b12ff328e0fc76

Author: David Gibson <[email protected]>
Date:   Tue Dec 8 14:24:42 2009 +1100

extends the position mechanism with columns, but considers a tab to be 8 column. Would it be ok to drop this feature? I have the impression that counting 1 column for a tab would be more useful for actually finding the referenced code.

Quoted 6 lines

Hrm. I set it up that way initially so that the reported columns would match what shows up inside an editor (e.g. emacs 'column-number-mode').

So, I think I'll need to see a more developed case for why not expanding tabs this way is preferable before making the change.

OK, my emacs doesn't show column numbers. I make a macro that moves forward one space, and run that macro, eg 28 times, which ends up in the wrong place. But if you prefer tabs to count as 8, I can leave it as it is.

julia

#4 lore raw
Quoted 24 lines · Julia Lawall
Quoted 20 lines · David Gibson
Quoted 18 lines · Julia Lawall

Hello,

I have been working with Frank Rowand on a v7 of file and line number annotations in the -O dts output of the device tree compiler.

I wanted to make an --annotate-full option that would print the full filename, and starting and ending line and column numbers.

The following commit:

commit 728c5e87c655c17c2fbc1d5386b12ff328e0fc76

Author: David Gibson <[email protected]>
Date:   Tue Dec 8 14:24:42 2009 +1100

extends the position mechanism with columns, but considers a tab to be 8 column. Would it be ok to drop this feature? I have the impression that counting 1 column for a tab would be more useful for actually finding the referenced code.

Quoted 8 lines
Quoted 6 lines

Hrm. I set it up that way initially so that the reported columns would match what shows up inside an editor (e.g. emacs 'column-number-mode').

So, I think I'll need to see a more developed case for why not expanding tabs this way is preferable before making the change.

OK, my emacs doesn't show column numbers.

Its not on by default; M-x 'column-number-mode' should enable it. I don't actually know if it always treats tabs as 8 columns, or if there's some magic variable controlling how it treats tabs. Given it's emacs, probably the latter.

Fwiw, I don't usually use vi, but I had a quick poke in vim and it seems to show both tab-unexpanded and tab-expanded numbers for the columns (when pressing ^G, anyway).

Quoted 3 lines

I make a macro that moves
forward one space, and run that macro, eg 28 times, which ends up in the wrong place.

That is a good point.

Quoted 2 lines

But if you prefer tabs to count as 8, I can leave it as it is.

I'm no longer sure which I prefer :/

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson