Skip to contentSkip to conversation

Makefile: make modules install output

DISCUSSION Julia Lawall 2 participants 2 messages Jun 9, 2021 Kbuild

lore
Share & tools
lore
#0 lore raw

make modules install used to end up with something like

INSTALL sound/usb/usx2y/snd-usb-usx2y.ko
INSTALL sound/x86/snd-hdmi-lpe-audio.ko
INSTALL sound/xen/snd_xen_front.ko
INSTALL virt/lib/irqbypass.ko
DEPMOD 5.12.0-rc2myfix-00015-gc6f886546cb8

From v5.13-rc1, it gives:

  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/fs/xfs/xfs.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/net/mac80211/mac80211.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko
  DEPMOD  /lib/modules/5.13.0-rc1myfix

Is the full path name considered to be an improvement? For the names of the modules, it doesn't much matter, but the DEPMOD line was a convenient way to get the full kernel name for subsequent rebooting.

thanks,
julia

#1 lore raw
Quoted 11 lines · Julia Lawall

make modules install used to end up with something like

INSTALL sound/usb/usx2y/snd-usb-usx2y.ko
INSTALL sound/x86/snd-hdmi-lpe-audio.ko
INSTALL sound/xen/snd_xen_front.ko
INSTALL virt/lib/irqbypass.ko
DEPMOD 5.12.0-rc2myfix-00015-gc6f886546cb8

From v5.13-rc1, it gives:

Quoted 8 lines
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/fs/xfs/xfs.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/net/mac80211/mac80211.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko
  STRIP   /lib/modules/5.13.0-rc1myfix/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko
  DEPMOD  /lib/modules/5.13.0-rc1myfix

Is the full path name considered to be an improvement?

I think so.
It is clear where the files are being installed to.

Another motivation was rather to make it aligned with the convention.

Kbuild log convention is this form:

[ACTION] [DESTINATION]

For example, when Kbuild is building kernel/foo.c
into kernel/foo.o

CC kernel/foo.o

is shown.

In this case, Kbuild is installing kernel/fs/btrfs/btrfs.ko to /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko

So, I think it is more consistent to show the destination rather than the source.

Quoted 6 lines

For the names of
the modules, it doesn't much matter, but the DEPMOD line was a convenient way to get the full kernel name for subsequent rebooting.

thanks,
julia

Signature · 2 lines
Best Regards
Masahiro Yamada