Skip to contentSkip to conversation

Drop "init_mm" from being exported via EXPORT_UNUSED_SYMBOL.

PATCH In review Robert P. J. Day 2 participants 2 messages Apr 24, 2008 – Apr 25, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drop "init_mm" from being exported via EXPORT_UNUSED_SYMBOL.

---

since this was listed as removable as of 2.6.26, does that mean its
removal can go into an appropriate tree now? or would that mean *after* the release of 2.6.26?

arch/x86/kernel/init_task.c +0 -1
index 3d01e47..5b3ce79 100644
@@ -15,7 +15,6 @@ static struct files_struct init_files = INIT_FILES;
 static struct signal_struct init_signals = INIT_SIGNALS(init_signals);
 static struct sighand_struct init_sighand = INIT_SIGHAND(init_sighand);
 struct mm_struct init_mm = INIT_MM(init_mm);
-EXPORT_UNUSED_SYMBOL(init_mm); /* will be removed in 2.6.26 */
 
 /*
  * Initial thread structure.

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

#1 lore raw
Quoted 8 lines · Robert P. J. Day

---

since this was listed as removable as of 2.6.26, does that mean its
removal can go into an appropriate tree now? or would that mean *after* the release of 2.6.26?

Davem mentioned this has valid use-cases on non-x86 architectures because it's exposed through mm macros. So please audit it's users and make sure the export is only dropped for architectures where it's not actually needed.