dmapools: protect page_list walk in show_pools()
Subsystems (2)
PATCH 1/1 dmapools: protect page_list walk in show_pools()
show_pools() walks the page_list of a pool w/o protection against the list modifications in alloc/free. Take pool->lock to avoid stomping into nirvana.
Signed-off-by Thomas Gleixner <[email protected]>
---
mm/dmapool.c +2 -0
@@ -86,10 +86,12 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)unsigned pages =0 ;unsigned blocks =0 ; +spin_lock_irq (&pool->lock);list_for_each_entry (page, &pool->page_list, page_list) { pages++; blocks += page->in_use; } +spin_unlock_irq (&pool->lock);/* per-pool info, no real statistics yet */ temp = scnprintf(next, size, "%-16s %4u %4Zu %4Zu %2u\n",
Quoted 5 lines · Thomas Gleixner
show_pools()walks thepage_listof a pool w/o protection against the list modifications in alloc/free. Takepool->lockto avoid stomping into nirvana.Signed-off-by Thomas Gleixner <[email protected]>
Looks right to me. We're already holding pools_lock here, but pools_lock doesn't protect against the page_list.
Signed-off-by Matthew Wilcox <[email protected]>
I don't have a tree for dmapool work ... might as well go in through Andrew, I suppose?
Quoted 20 lines
---
mm/dmapool.c +2
-0@@ -86,10 +86,12 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)unsigned pages =0 ;unsigned blocks =0 ; +spin_lock_irq (&pool->lock);list_for_each_entry (page, &pool->page_list, page_list) { pages++; blocks += page->in_use; } +spin_unlock_irq (&pool->lock);/* per-pool info, no real statistics yet */ temp = scnprintf(next, size, "%-16s %4u %4Zu %4Zu %2u\n",
Signature · 4 lines
Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."