Skip to contentSkip to conversation

irq fixes for 2.6.31

GIT PULL Thomas Gleixner 2 participants 5 messages Aug 17, 2009 – Aug 18, 2009 IRQ

lore
Share & tools
lore
#0 lore raw

Linus,

Please pull the latest irq-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq-fixes-for-linus

Thanks,

tglx

------------------>
Thomas Gleixner (1):

      genirq: Do not wakeup irq thread from __setup_irq() and set action->irq
 kernel/irq/manage.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
kernel/irq/manage.c +1 -2
index d222515..76fa62f 100644
@@ -607,7 +607,6 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 		 */
 		get_task_struct(t);
 		new->thread = t;
-		wake_up_process(t);
 	}
 
 	/*
@@ -690,6 +689,7 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 				(int)(new->flags & IRQF_TRIGGER_MASK));
 	}
 
+	new->irq = irq;
 	*old_ptr = new;
 
 	/* Reset broken irq detection when installing new handler */
@@ -707,7 +707,6 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 
 	spin_unlock_irqrestore(&desc->lock, flags);
 
-	new->irq = irq;
 	register_irq_proc(irq, desc);
 	new->dir = NULL;
 	register_handler_proc(irq, new);
#1 lore raw
Quoted 9 lines · Thomas Gleixner

Please pull the latest irq-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq-fixes-for-linus

Thanks,

tglx

Quoted 7 lines

------------------>
Thomas Gleixner (1):

      genirq: Do not wakeup irq thread from __setup_irq() and set action->irq
 kernel/irq/manage.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

This is not what I get when I pull. Instead I get the "genirq: Prevent race between free_irq() and handle_IRQ_event()" commit that I thought we agreed wasn't correct.

Linus

#2 lore raw

Linus,

Quoted 15 lines · Linus Torvalds
Quoted 14 lines · Thomas Gleixner

Please pull the latest irq-fixes-for-linus git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq-fixes-for-linus

Thanks,

tglx

------------------>
Thomas Gleixner (1):

      genirq: Do not wakeup irq thread from __setup_irq() and set action->irq
Quoted 6 lines
Quoted 2 lines
 kernel/irq/manage.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

This is not what I get when I pull. Instead I get the "genirq: Prevent race between free_irq() and handle_IRQ_event()" commit that I thought we agreed wasn't correct.

I have no idea what went wrong this time. I force pushed the branch and pulled it back on a test machine to compile and test boot. The test machine still has the correct sha1 for that branch while master.kernel.org did not. I probably pushed out some other branch between the point where I sent the pull request and the time you pulled, but I can not find any hint in my bash history which would explain why it wreckaged the irq-fixes-for-linus branch.

Just double checked that it is pushed out to git://.... as well.

Thanks,

tglx

#3 lore raw
Quoted 10 lines · Thomas Gleixner

I have no idea what went wrong this time. I force pushed the branch and pulled it back on a test machine to compile and test boot. The test machine still has the correct sha1 for that branch while master.kernel.org did not. I probably pushed out some other branch between the point where I sent the pull request and the time you pulled, but I can not find any hint in my bash history which would explain why it wreckaged the irq-fixes-for-linus branch.

Just double checked that it is pushed out to git://.... as well.

It's still wrong.

	http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=shortlog;h=irq-fixes-for-linus

still does _not_ show that

	genirq: Do not wakeup irq thread from __setup_irq() and set action->irq

commit, but the broken one.

Linus

#4 lore raw
Quoted 14 lines · Linus Torvalds
Quoted 10 lines · Thomas Gleixner

I have no idea what went wrong this time. I force pushed the branch and pulled it back on a test machine to compile and test boot. The test machine still has the correct sha1 for that branch while master.kernel.org did not. I probably pushed out some other branch between the point where I sent the pull request and the time you pulled, but I can not find any hint in my bash history which would explain why it wreckaged the irq-fixes-for-linus branch.

Just double checked that it is pushed out to git://.... as well.

It's still wrong.

Quoted 7 lines
	http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=shortlog;h=irq-fixes-for-linus

still does _not_ show that

	genirq: Do not wakeup irq thread from __setup_irq() and set action->irq

commit, but the broken one.

Err, no. Please see the mail I sent an hour ago.

Even the http.... interface shows the one I want you to pull:

     69ab849439b506cd8dd2879527fdb64d95dd5211

Thanks,

tglx