Skip to contentSkip to conversation

mismatch in MTD Kconfig variables

DISCUSSION Robert P. J. Day 2 participants 3 messages Sep 8, 2009 – Sep 9, 2009 Memory technology devices (MTD)

lore
Share & tools
lore

Robert P. J. Day

author
#0 lore raw

result of latest kernel tree scan:

$ grep -r MTD_DATAFLASH.*VERIFY  drivers
drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
drivers/mtd/devices/mtd_dataflash.c:#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
drivers/mtd/devices/Kconfig:config MTD_DATAFLASH_WRITE_VERIFY
$

note the mismatch in the spelling -- "VERIFY_WRITE" vs
"WRITE_VERIFY".

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw
Quoted 8 lines · Robert P. J. Day

result of latest kernel tree scan:

$ grep -r MTD_DATAFLASH.*VERIFY  drivers
drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
drivers/mtd/devices/mtd_dataflash.c:#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
drivers/mtd/devices/Kconfig:config MTD_DATAFLASH_WRITE_VERIFY
$

So you have a patch to fix this?

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
author
#2 lore raw
Quoted 4 lines · Artem Bityutskiy
Quoted 3 lines · Robert P. J. Day

result of latest kernel tree scan:

Quoted 8 lines
Quoted 6 lines
$ grep -r MTD_DATAFLASH.*VERIFY  drivers
drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
drivers/mtd/devices/mtd_dataflash.c:#endif	/*
CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
drivers/mtd/devices/Kconfig:config MTD_DATAFLASH_WRITE_VERIFY
$

So you have a patch to fix this?

as long as someone else confirms that, yes, it's just a typo and
those two variables should match, then yes, i can have a patch in short order.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================