Skip to contentSkip to conversation

Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE

PATCH In review Robert P. J. Day 2 participants 3 messages Sep 10, 2009 Memory technology devices (MTD)

lore
Share & tools
lore

Robert P. J. Day

author
#0 lore raw

PATCH 1/1 Kconfig: MTD_DATAFLASH_WRITE_VERIFY -> MTD_DATAFLASH_VERIFY_WRITE

Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so that it matches the spelling here:

drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */

Signed-off-by Robert P. J. Day <[email protected]>

---

drivers/mtd/devices/Kconfig +1 -1
index 325fab9..3265e96 100644
@@ -59,7 +59,7 @@ config MTD_DATAFLASH
 	  Sometimes DataFlash chips are packaged inside MMC-format
 	  cards; at this writing, the MMC stack won't handle those.
 
-config MTD_DATAFLASH_WRITE_VERIFY
+config MTD_DATAFLASH_VERIFY_WRITE
 	bool "Verify DataFlash page writes"
 	depends on MTD_DATAFLASH
 	help

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Robert" == Robert P J Day <[email protected]> writes:

Robert> Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so Robert> that it matches the spelling here:

Robert> drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
Robert> drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */

Robert> -config MTD_DATAFLASH_WRITE_VERIFY
Robert> +config MTD_DATAFLASH_VERIFY_WRITE

It probably makes more sense to change the .c file instead of Kconfig, to not bother/confuse people and simply make it "just work".

Signature · 1 line
Bye, Peter Korsgaard
author
#2 lore raw
Quoted 5 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Robert" == Robert P J Day <[email protected]> writes:

Robert> Fix the misspelled Kconfig variable "MTD_DATAFLASH_WRITE_VERIFY" so Robert> that it matches the spelling here:

Quoted 8 lines

Robert> drivers/mtd/devices/mtd_dataflash.c:#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
Robert> drivers/mtd/devices/mtd_dataflash.c:#endif /* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */

Robert> -config MTD_DATAFLASH_WRITE_VERIFY
Robert> +config MTD_DATAFLASH_VERIFY_WRITE

It probably makes more sense to change the .c file instead of Kconfig, to not bother/confuse people and simply make it "just work".

ok, if that's the consensus, i'll have that patch out later today.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================