Skip to contentSkip to conversation

UM: Remove BKL from sys_execve

PATCH New John Kacur 1 participant 1 message Oct 18, 2009 User-mode Linux (UML)

lore
Share & tools
lore

John Kacur

author
#0 lore raw

PATCH 1/1 UM: Remove BKL from sys_execve

Quoted 1 line

From 4d71a5e17b985a8fefaa88e3a6fe4896878886ba Mon Sep 17 00:00:00 2001

From: John Kacur <[email protected]>
Date: Sun, 18 Oct 2009 16:17:57 +0200
Subject: [PATCH] UM: Remove BKL from sys_execve

The BKL in sys_execve is likely the result of a cut-and-paste from a time, when it was needed. However, it is no longer required here. Remove to be in sync with other architectures.

(See arch/x86/kernel/process_64.c for example)

---
 arch/um/kernel/exec.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
arch/um/kernel/exec.c +2 -5
index fda30d2..d39aa36 100644
@@ -5,7 +5,6 @@
 
 #include "linux/stddef.h"
 #include "linux/fs.h"
-#include "linux/smp_lock.h"
 #include "linux/ptrace.h"
 #include "linux/sched.h"
 #include "asm/current.h"
@@ -76,13 +75,11 @@ long sys_execve(char __user *file, char __user *__user *argv,
 	long error;
 	char *filename;
 
-	lock_kernel();
 	filename = getname(file);
 	error = PTR_ERR(filename);
-	if (IS_ERR(filename)) goto out;
+	if (IS_ERR(filename))
+		return error;
 	error = execve1(filename, argv, env);
 	putname(filename);
- out:
-	unlock_kernel();
 	return error;
 }
Signature · 1 line
1.6.0.6