capabilities: Use RCU to protect task lookup in sys_capget
PATCH 1/1 capabilities: Use RCU to protect task lookup in sys_capget
cap_get_target_pid() protects the task lookup with tasklist_lock. security_capget() is called under tasklist_lock as well but tasklist_lock does not protect anything there. The capabilities are protected by RCU already.
So tasklist_lock only protects the lookup and prevents the task going away, which can be done with rcu_read_lock() as well.
--- kernel/capability.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/capability.c +2 -2
@@ -135,7 +135,7 @@ static inline int cap_get_target_pid(pidif (pid && (pid !=task_pid_vnr (current))) {struct task_struct *target; -read_lock (&tasklist_lock); +rcu_read_lock (); target =find_task_by_vpid (pid);if (!target)
@@ -143,7 +143,7 @@ static inline int cap_get_target_pid(pidelse ret =security_capget (target, pEp, pIp, pPp); -read_unlock (&tasklist_lock); +rcu_read_unlock (); }else ret =security_capget (current, pEp, pIp, pPp);
Quoted 9 lines · Thomas Gleixner
cap_get_target_pid()protects the task lookup withtasklist_lock.security_capget()is called undertasklist_lockas well buttasklist_lockdoes not protect anything there. The capabilities are protected by RCU already.So
tasklist_lockonly protects the lookup and prevents the task going away, which can be done withrcu_read_lock()as well.Signed-off-by Thomas Gleixner <[email protected]>
Applied togit://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
Signature · 2 lines
James Morris <[email protected]>